Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding an .editorconfig to enforce aspects of the style guide #1205

Open
iamgollum opened this issue Jul 9, 2019 · 1 comment · May be fixed by #1206
Open

Consider adding an .editorconfig to enforce aspects of the style guide #1205

iamgollum opened this issue Jul 9, 2019 · 1 comment · May be fixed by #1206

Comments

@iamgollum
Copy link
Contributor

iamgollum commented Jul 9, 2019 •
edited

When I was working on issue #1202, I noticed in my PR that the format was off. I went to check the repo and noticed there was no .editorconfig. This can help standardize styling across os / contributors.

https://github.com/apache/couchdb-fauxton/blob/master/styleguide.md

Aka for a base:

root = true

[*]
indent_style = space
indent_size = 2
@popojargo
Copy link
Member

I would be +1 on this. We already have eslint for code formatting but a .editorconfig would also helps being consistent in the different files.

iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 9, 2019
Added base editor config based on styleguide - apache#1205
6c93cf4
@iamgollum iamgollum linked a pull request Jul 9, 2019 that will close this issue
Open
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 9, 2019
Added base editor config based on styleguide - apache#1205
37b86c5
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 9, 2019
Added base editor config based on styleguide - apache#1205
bee4730
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 13, 2019
Added prettier with staged commit hook - apache#1205
72ebd9c
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 14, 2019
Added prettier with staged commit hook - apache#1205
24113df
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 14, 2019
Added prettier with staged commit hook - apache#1205
22f8969
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 14, 2019
Added prettier with staged commit hook - apache#1205
ab86b2a
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 14, 2019
Added prettier with staged commit hook - apache#1205
508c3f4
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 14, 2019
Added prettier with staged commit hook - apache#1205
f7fa336
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 14, 2019
Added prettier with staged commit hook - apache#1205
d7491a3
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 14, 2019
Added prettier with staged commit hook - apache#1205
820bc73
iamgollum pushed a commit to iamgollum/couchdb-fauxton that referenced this issue Jul 14, 2019
Added prettier with staged commit hook - apache#1205
66a8775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added editor config based on styleguide - #1205 iamgollum/couchdb-fauxton
2 participants
@iamgollum @popojargo