Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use c8 for coverage #70

Closed
brodybits opened this issue Jan 23, 2019 · 3 comments
Closed

Use c8 for coverage #70

brodybits opened this issue Jan 23, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@brodybits
Copy link

I just discovered bcoe/c8 (c8) which does NYC/Istanbul code coverage using Node.js v8 coverage. This would require Node.js version 10 but I cannot see why we would need to run coverage on older Node.js versions.

I would NOT recommend we do this before Cordova 9 is finished.

Discovered via tapjs/tapjs#493

@brodybits brodybits added the enhancement New feature or request label Jan 23, 2019
@janpio
Copy link
Member

janpio commented Jan 23, 2019

What is the disadvantage of using nyc/istanbul? Speed as mentioned in the linked issue?

@brodybits
Copy link
Author

Speed as mentioned in the linked issue?

Yes. Maybe not major but I would favor choosing the more efficient tooling if there are no other factors against it.

@raphinesse
Copy link
Contributor

raphinesse commented Sep 23, 2020

I would argue that we have enough work in our hands and performance is not a problem at the moment. Furthermore, nyc is well maintained AFAICT and its adoption is much greater than that of c8. Interesting to see that there are alternatives though.

Who knows maybe nyc will even start to use c8 itself if it is that much faster. This way we wouldn't have to do any of the work 😄

I would propose to do do nothing and close this issue. Objections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants