Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Allow drop non-empty external catalogs #2735

Open
3 tasks done
link3280 opened this issue Apr 11, 2024 · 0 comments
Open
3 tasks done

[Bug]: Allow drop non-empty external catalogs #2735

link3280 opened this issue Apr 11, 2024 · 0 comments

Comments

@link3280
Copy link
Contributor

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, it's forbidden to remove a non-empty catalog if a catalog has managed tables. However, the implementation actually checks all tables, not only the managed ones. As a result, external catalogs can never be removed.

public List<ServerTableIdentifier> listManagedTables(String catalogName) {
checkStarted();
return getAs(
TableMetaMapper.class, mapper -> mapper.selectTableIdentifiersByCatalog(catalogName));
}

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant