Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on March 03, 2023 #29901

Closed
25 of 40 tasks
eladkal opened this issue Mar 3, 2023 · 21 comments
Closed
25 of 40 tasks

Status of testing Providers that were prepared on March 03, 2023 #29901

eladkal opened this issue Mar 3, 2023 · 21 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@eladkal
Copy link
Contributor

eladkal commented Mar 3, 2023

Body

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider amazon: 7.3.0rc1

Provider apache.flink: 1.0.1rc1

Provider apache.livy: 3.3.0rc1

Provider atlassian.jira: 2.0.1rc1

Provider cncf.kubernetes: 5.2.2rc1

Provider common.sql: 1.3.4rc1

Provider dbt.cloud: 3.1.0rc1

Provider github: 2.2.1rc1

Provider google: 8.11.0rc1

Provider hashicorp: 3.3.0rc1

Provider mysql: 4.0.2rc1

Provider sftp: 4.2.4rc1

Provider ssh: 3.5.0rc1

Provider telegram: 4.0.0rc1

Provider yandex: 3.3.0rc1

The guidelines on how to test providers can be found in Verify providers by contributors

All users involved in the PRs:
@kristopherkane @sunank200 @LMnet @phanikumv @jose-lpa @pdebelak @ferruzzi @vincbeck @r-richmond @vandonr-amz @eladkal @wiktorn @maxnathaniel @pgagnon @hussein-awala @bkossakowska @Taragolis
@pankajastro @fritz-astronomer @romibuzi @josh-fell @lwyszomi @potiuk @s0neq @Aakcht @FloMom @IKholopov @yehoshuadimarsky

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added kind:meta High-level information important to the community testing status Status of testing releases labels Mar 3, 2023
@eladkal
Copy link
Contributor Author

eladkal commented Mar 3, 2023

Contributors are also encouraged to cast non-binding vote in the mailing list thread.

@s0neq
Copy link
Contributor

s0neq commented Mar 3, 2023

Provider yandex: 3.3.0rc1 has been tested. all is fine 👌

@vandonr-amz
Copy link
Contributor

all good for me as it's covered by a system test that's green

@fritz-astronomer
Copy link
Contributor

Snowflake change has unit test coverage 👍

@hussein-awala
Copy link
Member

Provider google: 8.11.0rc1 : I tested #29394 and it works as expected.
Provider sftp: 4.2.4rc1: Same for #29794.
Provider hashicorp: 3.3.0rc1: I have tested #29734 and it works, but currently we should use the same variables, config and connections paths for all the mount points because there is a bug in the Vault secrets backend, I wonder if we can add #29908 to this release or we add it to the next one.

@eladkal
Copy link
Contributor Author

eladkal commented Mar 3, 2023

@hussein-awala I will cancel RC1 for hashicorp provider and will cut RC2 after the current vote

@Aakcht
Copy link
Contributor

Aakcht commented Mar 4, 2023

Tested #29347 for SSH provider 3.5.0rc1 - works as expected. Waiting for full release!

@Taragolis
Copy link
Contributor

@potiuk
Copy link
Member

potiuk commented Mar 4, 2023

  • Checked flink -> it has the right >= 5.1.0 requirement on cncf.kubernetes 👍
  • Checked google -> the constants from auth library are properly inlined 👍

Looks good.

@pdebelak
Copy link
Contributor

pdebelak commented Mar 4, 2023

I checked apache-airflow-providers-amazon and the change in #29708 is working as expected.

@maxnathaniel
Copy link
Contributor

Provider telegram: 4.0.0rc1 works as expected 👍

@pankajastro
Copy link
Member

#29657 #29348 and #29364 Looks good

@romibuzi
Copy link
Contributor

romibuzi commented Mar 6, 2023

#29659 working as expected

@raphaelauv
Copy link
Contributor

for the kubernetes the name of the feature is incorrect

KubernetesPodOperator._render_nested_template_fields improved by changing the conditionals for a map (#29760): @jose-lpa

->

KubernetesPodOperator._render_nested_template_fields improved by changing the conditionals (#29760): @jose-lpa

( there is no map )

@eladkal
Copy link
Contributor Author

eladkal commented Mar 6, 2023

for the kubernetes the name of the feature is incorrect

KubernetesPodOperator._render_nested_template_fields improved by changing the conditionals for a map (#29760): @jose-lpa

->

KubernetesPodOperator._render_nested_template_fields improved by changing the conditionals (#29760): @jose-lpa

( there is no map )

The release mechanism currently does not allow us to change the commit messages. Probably something we need to improve on in the future.
Since this is only issue with the commit title and not with the actual functionality I see no reason why we can't continue with release of this package.

@josh-fell
Copy link
Contributor

#29741, #29699, and #29549 look good.
Thanks for organizing @eladkal!

@pgagnon
Copy link
Contributor

pgagnon commented Mar 6, 2023

#29623 working as expected.

@IKholopov
Copy link
Contributor

#29680 is effectively a noop (for now) and it is working as expected :)

@kristopherkane
Copy link
Contributor

#29136 Has been tested with real Google Cloud resources successfully.

@eladkal
Copy link
Contributor Author

eladkal commented Mar 6, 2023

Thank you everyone.
Providers are released
I invite everyone to help improve providers for the next release, a list of open issues can be found here.

@eladkal eladkal closed this as completed Mar 6, 2023
@LMnet
Copy link
Contributor

LMnet commented Mar 6, 2023

#29434 has a unit test and also I use the same code locally in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests