Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes embed syntax highlighting #135

Open
AceofSpades5757 opened this issue Jul 1, 2020 · 5 comments
Open

Removes embed syntax highlighting #135

AceofSpades5757 opened this issue Jul 1, 2020 · 5 comments
Labels

Comments

@AceofSpades5757
Copy link

In .vim files, it will remove the embed syntax highlighting. This was confirmed with Python code inside of a .vim file.

Vim Version: 8.1

I wasn't able to find a setting that the plugin altered, or a script that overwrote the highlighting, but it will immediately remove the highlighting when run.

@ap
Copy link
Owner

ap commented Aug 9, 2020

Hi @AceofSpades5757, thank you for the report. Sorry I took so long to react.

I’m not sure what you mean… can you make some screenshots maybe? One of how it’s supposed to look (without the plugin?), one that shows what happens instead, or something?

@AceofSpades5757
Copy link
Author

I'm referring to embedded syntax highlighting inside vim files. For example, Python inside the py3 << EOF blocks that gets highlighted as Python code instead of Vimscript.

Rather than try and figure out exactly why this was happening, I just put this plugin in an opt folder so it wasn't run with vim files. Still not sure why this was happening.

@ap
Copy link
Owner

ap commented Aug 9, 2020

I am still interested in finding out. 🙂

Can you give me (or point me at) an example file where this definitely broke for you? (You have already given me enough that I can try to reconstruct something myself – but if my test case doesn’t reproduce the bug, I couldn’t tell whether it’s because I constructed the wrong test case or whether it isn’t reproducible on my setup.)

@ap ap added the bug label Aug 9, 2020
@AceofSpades5757
Copy link
Author

So I was looking over it recently, and just tonight. Recently, I switched to vim-plug which was set to only load vim-css-color for CSS files, so it looked like something else was breaking it. Sadly, that wasn't the case. I guess vim-plug still loads something, because the only way I've been able to get the embedded highlighting to work is by commenting out the vim-css-color line.

So, I'm not sure what that means exactly, but now that I'm 100% sure it's vim-css-color I'll get a dummy example soon. I say soon, because I think I had to set an option in base Vim, add a plugin script to extend a highlighting block, and had some troubleshooting issues previously that I simply don't remember offhand.

Anything in particular you need? Or would find useful in addition?

EDIT: It has something to do with the vim-css-color/after/syntax/python.vim file.

  • Before filename change: Embedded syntax broken
  • After filename change: Embedded syntax works
  • Changed filename back to normal: Embedded syntax broken again

@ap
Copy link
Owner

ap commented Sep 28, 2020

Well… sure. That file is what loads CSS Color into Python buffers. Changing its filename causes that not to happen. That’s why the problem stops – it’s no longer getting loaded in Python buffers, where it was causing the problem, so the problem stops. That doesn’t fix the problem though…

Anything in particular you need? Or would find useful in addition?

Again, if you have an example file that I can open in Vim and see for myself what changes depending on whether the plugin is enabled or not, that would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants