Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor correlation with coastlines #19

Open
jolyonralph opened this issue Nov 24, 2021 · 2 comments
Open

Poor correlation with coastlines #19

jolyonralph opened this issue Nov 24, 2021 · 2 comments

Comments

@jolyonralph
Copy link

There seems to be a poor correlation with coastlines in many cases - for example going to 1815-1920 and looking at the United Kingdom of Great Britain and Ireland, a lot of the coastal areas (and many of the surrounding islands including the Orkneys, Shetlands, Isle of Wight and Anglesey) are excluded.

I appreciate that you want to keep the polygon size small, but this would be better done by drawing the coastal borders around the island(s) rather than inside. It won't be an accurate capture of territorial waters of the time but what it will do is capture correctly all coordinates within the territory on land, which the current data fails to do.

I'm looking at this as a way of being able to map existing data points on land and see which territories they fell into in the historical past - but these polygons currently don't do this effectively because they are clipping out significant parts of coastal regions.

Is there any intent to fix this, or will I have to fork the data and work on this myself?

@jolyonralph
Copy link
Author

Or, if it's helpful, I'm happy to contribute such edits back to this project directly - what is the recommended geojson editor for working on these files?

@aourednik
Copy link
Owner

@jolyonralph : I totally agree. The islands, especially, often played - and still do - important strategic roles in the demarcotory process of territorial waters, something that would also need to be added. The original dataset is indeed poorely aligned with coastal lines; I've already amended it in some cases, like the Carribean or Danemark, for some years.
Your help would be much appreciated. I recommend editing with the open-source tool QGIS. However: doing this by hand represents a tremendous amount of work. Best woul be to find an automatized way to snap the current data to better-defined continetal polygons. QGIS provides a geometry snapping python class that could allow to write a script for doing so; I did not have time to give it a closer look yet, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants