Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keka asks for file access permission even when given "Full Disk Access" #1408

Open
Feuermurmel opened this issue Mar 4, 2024 · 4 comments
Open

Comments

@Feuermurmel
Copy link

Configuration

  • Keka version: 1.3.7
  • macOS version: 12.7.3 (21H1015)

Describe the bug

It seems that Keka will ask for permission to access the destination directory, even when given Full Disk Access in System Preferences.

To Reproduce

Steps to reproduce the behavior:

  1. Add Keka to list of apps given Full Disk Access in the Security & Privacy pane of System Preferences.
  2. Relaunch Keka.
  3. Start a compression job by dragging something onto the main window.
  4. The dialog saying "Keka has no file access to the destination folder so it needs to ask for a location" is shown.

Expected behavior

If given Full Disk Access, Keka should never have to ask for permission to access a directory.

Screenshots

Screen Shot 2024-03-04 at 20 54 35 Screen Shot 2024-03-04 at 20 54 28
@Feuermurmel Feuermurmel added the bug label Mar 4, 2024
@aonez aonez changed the title [BUG] Keka asks for file access permission even when given "Full Disk Access" Keka asks for file access permission even when given "Full Disk Access" Mar 5, 2024
@aonez
Copy link
Owner

aonez commented Mar 5, 2024

Even if the title "Full Disk Access" may suggest it, it does not give any direct file access to Keka. That just gives access (once you drop or open with Keka) to certain sensitive folders that otherwise will be blocked.

If you want Keka to have full disk access enable it on the Keka Preferences - File Access adding your disk to the access list:

Screenshot 2024-03-05 at 09 19 39

@aonez aonez added this to the How-to milestone Mar 5, 2024
@Feuermurmel
Copy link
Author

Thanks for the explanation! Adding the my system disk to the list in Preferences does exactly what I want.

I assumed that adding Keka to the "Full Disk Access" list in System Preferences would be enough to give Keka access without having to ask the user. I think with Terminal.app it works that way? Once I add it to that list, I can access everything from within a terminal session? Maybe I'm mistaken.

@aonez
Copy link
Owner

aonez commented Mar 11, 2024

@Feuermurmel the Terminal is not even sandboxed, so it does not need permission to access your files. I can deny Downloads folder access to the Terminal app and still read and write on that folder.

Keka is sandboxed so it really only has access on the folders you open/drop or assign (really the same) in the Keka's File Access Preferences.

@Feuermurmel
Copy link
Author

Feuermurmel commented Mar 15, 2024

@Feuermurmel the Terminal is not even sandboxed, so it does not need permission to access your files. I can deny Downloads folder access to the Terminal app and still read and write on that folder.

Not sure if we're talking about the same thing (read: I don't know anything about how macOS sandboxing works). But if I remove Terminal.app from the "Full Disk Access" and "Files and Folders" lists in "Privacy & Security" in System Preferences, I get the following dialog the next time I open Terminal and try to change to some folder:

image

I don't know if this is part of sandboxing. If I add Terminal.app to "Full Disk Access" before opening it, I don't get any of those dialogs, regardless of what I access.

I'm talking about the stock Terminal.app at /System/Applications/Utilities/Terminal.app btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants