-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docblock space indents are being flagged as incorrect #6
Comments
Not sure what's happening, but I tested it here now:
Forced one error and got this:
|
Hm, maybe try with a class docblock? Is it the spaces in column one that it's complaining about? |
My point was: your docblock flagging was not related to this package but to php_codesniffer: https://github.com/squizlabs/PHP_CodeSniffer. But I changed that class to do a full check with it:
And got
Anyway, you are not showing me any error messages, only saying But I don't think it's related to that space, because that one is supposed to be there. |
Sorry, I should've been more thorough earlier! :) I was being a bit slapdash. Here's the file I'm testing ( <?php
/**
* Blah.
*/
class Test {
} And error I'm getting:
|
Hmm... yeah, class doc blocks, I don't remember having touched them during development. Will have to take a look at it. But, anyway. Laravel 5.1 (May) is going to be PSR-2, so this package may not be needed anymore. :( |
Yes, I just read about that. These sniffs will still be required for older code though. But yeah, I think I'll start using PSR-2 now anyway, so don't worry too much about this issue. Thanks for helping! :) |
as @samwilson said I'm having a same problem, is this fixable? |
Is it correct that the following is not correct? (To mungle grammar at this early hour!)
There is a single space at the beginning of the second two lines, before the asterisks.
The text was updated successfully, but these errors were encountered: