Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Feature request: Support ManifestFilesMixin #204

Open
WhyNotHugo opened this issue Nov 9, 2020 · 3 comments
Open

Feature request: Support ManifestFilesMixin #204

WhyNotHugo opened this issue Nov 9, 2020 · 3 comments

Comments

@WhyNotHugo
Copy link

WhyNotHugo commented Nov 9, 2020

I'm using S3 with ManifestFilesMixin (it doesn't make sense to use S3 for staticfiles without it since invalidation becomes extremely complex and costly).:

from django.contrib.staticfiles.storage import ManifestFilesMixin
from storages.backends.s3boto3 import S3Boto3Storage


class MyStaticStorage(ManifestFilesMixin, S3Boto3Storage):
    """Storage that uses S3 and hashes in filenames to avoid caching issues."""

However, collectfast does not properly collect staticfiles. The manifest is missing, and no files are correctly copied onto the storage / bucket. There's no error though, and lots of processing is done for 2:45m.

I'm guessing that collectfast makes some [wrong] assumptions regarding the underlying setup, but I can't quite follow what that might be.

@antonagestam antonagestam changed the title Manifest is ignored Feature request: Support ManifestFilesMixin Nov 10, 2020
@antonagestam
Copy link
Owner

I'll review PRs implementing this.

@WhyNotHugo
Copy link
Author

I'm not quite sure where the bug is though, so don't think I'll be able to push a PR.

BTW: why is this labeled "feature request"? It's an actual bug -- the code makes an assumption about how files are stored that's not true for all use cases.

@antonagestam
Copy link
Owner

Because ManifestFilesMixin was not around when collectfast was first built and support for it has never been implemented. Since integration with ManifestFilesMixin has never been supported there can't be bugs in the integration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants