Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

NFS optimized strategy #191

Open
thenewguy opened this issue May 8, 2020 · 2 comments
Open

NFS optimized strategy #191

thenewguy opened this issue May 8, 2020 · 2 comments
Assignees

Comments

@thenewguy
Copy link
Contributor

I want to try this library out and noticed there isn't a strategy optimized for NFS type storage. Would you accept a PR that adds this strategy?

@thenewguy
Copy link
Contributor Author

The basic difference is the access speed. The filesystem storage recomputes the hash (https://github.com/antonagestam/collectfast/blob/master/collectfast/strategies/filesystem.py#L9) for remote files. It would be better to add an additional file that contains the hash on upload. Then the remote storage hash can just return the contents of the hash file

@antonagestam
Copy link
Owner

@thenewguy I'd definitely consider adding a strategy for NFS and I'll happy review pull requests if your willing to work on it.

I'd be hesitant to a solution that adds an extra file though, and would much prefer it the strategy could instead populate the cache the way you suggest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants