Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce diagnostics collection to monitor performance #134

Open
antoine-coulon opened this issue Jan 25, 2024 · 0 comments
Open

Introduce diagnostics collection to monitor performance #134

antoine-coulon opened this issue Jan 25, 2024 · 0 comments
Assignees
Labels
cli core enhancement New feature or request

Comments

@antoine-coulon
Copy link
Owner

Everything is summed up there #69 (comment)

The goal is to anonymously collect performance diagnostics to potentially establish performance issues related to graph sizes. Currently, skott is not collected any data. I didn't get much user feedbacks about performances but from my own experience it quickly gets ugly when having thousands of nodes, but especially high number of edges. The interesting there would be to be able to correlate graph size (nodes+edges) with performance and to see what should be improved.

Implementation

  1. Introduce a CLI flag to enable that collection, such as --collect-diagnostics. This flag would only collect diagnostics and generate a JSON file with summary. This would allow users to link it to issues, without relying on network calls to send the diagnostics to skott's backend.

  2. Introduce another CLI flag to enable and send collection, such as --send-diagnostics. This flag would basically collect (the same as the previous one) but instead of generating a file it would send the data right away to skott's backend.

  3. Then obviously, we would need a way to receive that data when using --send-diagnostics, using a custom web server. That server would then process in-coming diagnostics and only store diagnostics that is the payload, nothing from client information (IP etc).

@antoine-coulon antoine-coulon added enhancement New feature or request core cli labels Jan 25, 2024
@antoine-coulon antoine-coulon self-assigned this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant