Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

'Disabling Folding' preference leaves folding '+' visible in editor #119

Open
lukeu opened this issue Apr 28, 2015 · 2 comments
Open

'Disabling Folding' preference leaves folding '+' visible in editor #119

lukeu opened this issue Apr 28, 2015 · 2 comments

Comments

@lukeu
Copy link

lukeu commented Apr 28, 2015

In the preference [ANTLR4 > Folding] the master option "Enable Folding" is checked by default. Unchecking it does not seem to disable folding: the editor still displays (+) icons beside fold-able items.

I normally do not use this feature and disable it (e.g. in Java editors) to reduce visual clutter.

(I also thought that this option might provide a workaround for #102, but fortunately that's been resolved independently.)

See also #60.

@arifogel
Copy link
Member

arifogel commented Nov 6, 2016

Hi, I just picked up this project. To my knowledge, there is no feature to remove the folding icon altogether. The "Enable folding" checkbox simply initially folds the the elements in the section below it. The only change I would suggest would be visual on that preferences page:
Remove the text "Enable folding" and put the checkbox next to "Initially fold these elements". Then the checkboxes below should be greyed out whenever the top checkbox is unchecked.

The behavior you are expecting from "Enable Folding" would actually be a new feature.

Does this make sense?
If so:

  1. I will make the changes I mentioned.
  2. I encourage you to refile this as a feature request.

@arifogel arifogel self-assigned this Nov 6, 2016
@HSorensen HSorensen changed the title 'Enable Folding' preference doesn't have any effect 'Disabling Folding' preference leaves folding '+' visible in editor Nov 15, 2016
@HSorensen
Copy link
Member

@arifogel I think the bug is that when the "enable folding" is not selected there should not be any visible folding '+' within the editor. This, IMO, is different for the "initial fold these elements" options.

@arifogel arifogel removed their assignment Jan 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants