Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use linenoise-ng instead? #132

Closed
ghost opened this issue Dec 24, 2016 · 4 comments
Closed

Use linenoise-ng instead? #132

ghost opened this issue Dec 24, 2016 · 4 comments

Comments

@ghost
Copy link

ghost commented Dec 24, 2016

https://github.com/arangodb/linenoise-ng supports Windows.

Is it supposed to supersede this linenoise repo?

@Sonophoto
Copy link

Sonophoto commented Dec 24, 2016

Why did you open a new issue??? You were just discussing this in #113

@ghost
Copy link
Author

ghost commented Mar 17, 2017

Because that's a different issue

@antirez
Copy link
Owner

antirez commented Mar 17, 2017

Hello, there are a few things I would add like UTF8 minimal support (discussed in another issue), however to add support for Windows is currently not the goal, given that there is a fork that handles it. Remember that Linenoise design is specifically focusing simplicity... So as long they are small self-contained additions that are very useful, I'll add them, but if I see complex and/or C++ code, it's unlikely I'll merge. It's great that @fceller is providing an alternative, but linenoise-ng cannot be considered a set of patches on top of linenoise, more a spin-off project that changed language, goals, and so forth.

@antirez antirez closed this as completed Mar 17, 2017
@Sonophoto
Copy link

@antirez (FYI)

There are two other modified versions of linenoise:

@yhirose 's cpp version includes UTF-8 support, and windows:
https://github.com/yhirose/cpp-linenoise

@Sonophoto 's version is C, POSIX and supports UTF-8 and ANSI color.
https://github.com/Sonophoto/linenoise

I think we both watch your bug fixes and back-port them as appropriate. I think my last change was the history file permission issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants