New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use linenoise-ng instead? #132
Comments
Why did you open a new issue??? You were just discussing this in #113 |
Because that's a different issue |
Hello, there are a few things I would add like UTF8 minimal support (discussed in another issue), however to add support for Windows is currently not the goal, given that there is a fork that handles it. Remember that Linenoise design is specifically focusing simplicity... So as long they are small self-contained additions that are very useful, I'll add them, but if I see complex and/or C++ code, it's unlikely I'll merge. It's great that @fceller is providing an alternative, but linenoise-ng cannot be considered a set of patches on top of linenoise, more a spin-off project that changed language, goals, and so forth. |
@antirez (FYI) There are two other modified versions of linenoise: @yhirose 's cpp version includes UTF-8 support, and windows: @Sonophoto 's version is C, POSIX and supports UTF-8 and ANSI color. I think we both watch your bug fixes and back-port them as appropriate. I think my last change was the history file permission issue. |
https://github.com/arangodb/linenoise-ng supports Windows.
Is it supposed to supersede this linenoise repo?
The text was updated successfully, but these errors were encountered: