Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: add downloading option #169

Open
laur89 opened this issue Sep 2, 2022 · 1 comment
Open

FR: add downloading option #169

laur89 opened this issue Sep 2, 2022 · 1 comment

Comments

@laur89
Copy link
Contributor

laur89 commented Sep 2, 2022

Do I understand correctly joal is to be used for torrents that have actually been downloaded already? getDownloaded() value is hard-coded to 0 in TorrentSeedStats, so I'm guessing we never report any download. Which means it looks extremely suspicious if we'd feed a new torrent to joal without having downloaded it first, as it would report uploads, but no download.

If my assumption is correct, then it would be nice to add download announcements as well.

Unrelated, but perhaps it'd make sense to enable discussions in github repo for questions that don't really fit into issues section?

@laur89 laur89 mentioned this issue Nov 1, 2022
@anthonyraymond
Copy link
Owner

Hey :)

I'm thinking about adding this feature to the rework. It's a good idea to add it, but it will require another layer that i don't have time to add to the java version => "state persistence", you'll need to know if the torrent has been downloaded (fully or what percentage) when you restart JOAL from a previous version.

As it's not the usual practice, it is legit to get the content of the torrent (from a friend of yours or whatever) and start seeding it from your computer. It such case you'll start producing upload for non downloaded torrent.
Of course if you never download any torrents beforehand you may start to look suspicous.

That's the reason why i recommend downloading in your real torrent client before starting to seed in JOAL.

Openning the "discussions" tab is planned but i'll wait for the new version to be deployed. I'll replace the cotent of this repository with the new golang code once done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants