Light theme toolbar icon is not visible in incognito mode

[anthonyec]

Problem

Black toolbar icon is used in incognito mode.

Reproduce

• Allow extension in incognito mode
• Use the default light theme (black icon)
• Open incognito window
• Observe the black icon is not very visible on the dark window chrome

[anthonyec]

Possible ways to fix this:

• Check for incognito mode https://developer.chrome.com/extensions/extension#property-inIncognitoContext
• Add white background to black icon, and black background to white icon. Chrome documentation actually suggests not trying to make icons fit in with the rest of the UI (forgot where I saw but they do)
• Don't do anything for release
• Have option to turn off dynamic icon

[anthonyec]

The icon also does not work in dark themes in Chrome. Maybe I should just suck up and use a background colour on the icon

[anthonyec]

Be cool though if it could work like the incognito icon: