Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated tabs.executeScript method to new API #59

Open
anthonyec opened this issue Sep 15, 2021 · 1 comment
Open

Update deprecated tabs.executeScript method to new API #59

anthonyec opened this issue Sep 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@anthonyec
Copy link
Owner

https://developer.chrome.com/blog/crx-scripting-api/
https://developer.chrome.com/docs/extensions/reference/tabs/#method-executeScript

Is this review related?

Enrico B. da Luz gave you 3 stars and said:
"I love the idea but most bookmarklets don't work and some just fail silently. Any suggestions? Here's an example that fails silently: javascript:alert('hi')"
@anthonyec anthonyec added the bug Something isn't working label Sep 15, 2021
@anthonyec
Copy link
Owner Author

So far I can't reproduce this, only on "protected" pages like "chrome://" URLs or the Chrome Webstore. It would be good to add a warning as part of this fix to let people know when scripts can't be executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anthonyec