Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select menu item click closes filter panel #8231

Closed
maxprilutskiy opened this issue Nov 18, 2017 · 3 comments
Closed

Select menu item click closes filter panel #8231

maxprilutskiy opened this issue Nov 18, 2017 · 3 comments
Labels
🤔 Need Reproduce We cannot reproduce your problem

Comments

@maxprilutskiy
Copy link

maxprilutskiy commented Nov 18, 2017

Version

2.13.10

Environment

mac os x, react 15, latest chrome

Reproduction link

Demo

Steps to reproduce

  1. Create custom filter panel (uncontrolled, not using filterDropdownVisible) for Table component
  2. Place a select component inside custom filter panel JSX
  3. Click on select component to open the menu
  4. Click on menu item

What is expected?

I am expecting filter panel not to be closed until I click on reset / apply button or perform a click outside of filter panel

What is actually happening?

Filter panel closes


I am 99.99% sure that you guys use document click handler to track "outside" clicks, but as far as dropdown menu is appended to body your algorithm that most likely uses something like "if (!filterPanel.contains(clickSource)) { closeFilterPanel(); }" does not work in this case.

@ant-design-bot
Copy link
Contributor

Hello @prilutskiy. Please provide a online reproduction by forking this codepen https://codepen.io/pen?template=KgPZrE&editors=0010. Issues labeled by Need Reproduce will be closed if no activities in 7 days.

@afc163 afc163 added the 🤔 Need Reproduce We cannot reproduce your problem label Nov 22, 2017
@maxprilutskiy
Copy link
Author

Demo

@afc163
Copy link
Member

afc163 commented Nov 22, 2017

#3438

@afc163 afc163 closed this as completed Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤔 Need Reproduce We cannot reproduce your problem
Projects
None yet
Development

No branches or pull requests

3 participants