Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowtype support #7722

Closed
dperetti opened this issue Sep 24, 2017 · 8 comments
Closed

Flowtype support #7722

dperetti opened this issue Sep 24, 2017 · 8 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@dperetti
Copy link

What problem does this feature solve?

Provide Flow type checking and code suggestions.

What does the proposed API look like?

We just need a libdef like described here. https://flow.org/en/docs/libdefs/
It shouldn't be very complicated to achieve since it can probably be generated from Typescript definitions.

@benjycui
Copy link
Contributor

it can probably be generated from Typescript definitions.

Could your create a PR? Thanks.

@benjycui benjycui added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Sep 25, 2017
@afc163
Copy link
Member

afc163 commented Sep 30, 2017

I think we won't support it. Typescript is enough and better.

@afc163 afc163 closed this as completed Sep 30, 2017
@dperetti
Copy link
Author

"Better" you might think it is, not everybody shares that opinion. But that's not even the point. Nobody is asking you to move to javascript + Flow. You can and should, of course, keep going with Typescript.
This ticket was just about providing libdefs files for Flow compatibility, which I'm sure would delight many, many users in a near future.

@afc163
Copy link
Member

afc163 commented Sep 30, 2017

providing libdefs files for Flow compatibility

That is always welcome if someone could help us to make it happen. Feel free to propose a PR for it. I just say this is not our first priority now.

@soulmachine
Copy link

+1

@rahulthewall
Copy link

Did someone manage to generate the libdefs files?

@kishoremvrs
Copy link

https://github.com/rj254/antd-flow-types

Someone wrote some flow types.

Can someone validate these?

@adelespinasse
Copy link

It seems like there are Flow type definitions in the official flow-typed repo now:

https://github.com/flow-typed/flow-typed/tree/master/definitions/npm/antd_v3.x.x/flow_v0.104.x-

I have no idea how well they work (have not tried them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

7 participants