Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Slider show empty tooltip when tooltip.formatter is falsy #48673

Merged
merged 2 commits into from Apr 29, 2024
Merged

fix: Slider show empty tooltip when tooltip.formatter is falsy #48673

merged 2 commits into from Apr 29, 2024

Conversation

wanpan11
Copy link
Contributor

@wanpan11 wanpan11 commented Apr 28, 2024 •
edited by afc163

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #48668

💡 Background and solution

formatter=null 时没有隐藏 tooltip

📝 Changelog

Language Changelog
🇺🇸 English Fix Slider tooltip cannot be hidden when tooltip={{ formatter: null }}.
🇨🇳 Chinese 修复 Slider tooltip={{ formatter: null }} 无法隐藏 Tooltip 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 28, 2024 •
edited

👁 Visual Regression Report for PR #48673 Passed ✅

🎯 Target branch: master (0dd5617)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 28, 2024 •
edited

Preview is ready

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 28, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Apr 28, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cb19e0e) to head (383ea8d).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #48673   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        12946     12947    +1     
  Branches      3382      3383    +1     
=========================================
+ Hits         12946     12947    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanpan11 wanpan11 closed this Apr 28, 2024
@wanpan11 wanpan11 deleted the fix-slider branch April 28, 2024 13:24
@wanpan11 wanpan11 restored the fix-slider branch April 29, 2024 01:49
@wanpan11 wanpan11 reopened this Apr 29, 2024
Wxh16144
Wxh16144 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@Wxh16144 Wxh16144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@afc163 afc163 changed the title fix: slider tooltip is cant hide fix: Slider show empty tooltip when tooltip.formatter is falsy Apr 29, 2024
@afc163 afc163 merged commit c150885 into ant-design:master Apr 29, 2024
121 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。

@wanpan11 wanpan11 deleted the fix-slider branch April 29, 2024 02:40
@afc163 afc163 mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazyair crazyair crazyair left review comments

@afc163 afc163 afc163 approved these changes

@Wxh16144 Wxh16144 Wxh16144 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slider tooltip={{ formatter: null }} 隐藏 tooltip 后会有空的 tooltip 出现
4 participants
@wanpan11 @afc163 @crazyair @Wxh16144