Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(badge): number centered but slightly right-aligned #48605

Merged
merged 1 commit into from Apr 24, 2024
Merged

fix(badge): number centered but slightly right-aligned #48605

merged 1 commit into from Apr 24, 2024

Conversation

akinocccc
Copy link
Contributor

@akinocccc akinocccc commented Apr 24, 2024 •
edited

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #48593

💡 Background and solution

#48593

📝 Changelog

Language Changelog
🇺🇸 English Fix Badge number centered but slightly right-aligned.
🇨🇳 Chinese 修复 Badge 数字居中偏右

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Apr 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited

👁 Visual Regression Report for PR #48605 Passed ✅

🎯 Target branch: master (11a160c)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 24, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@akinocccc akinocccc changed the title fix(badge): text not centered fix(badge): number centered but slightly right-aligned Apr 24, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 24, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (11a160c) to head (cc31d3d).

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #48605   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        12946     12946           
  Branches      3382      3382           
=========================================
  Hits         12946     12946

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Apr 24, 2024

Check the visual diff.

@akinocccc
Copy link
Contributor Author

Check the visual diff.

Okay, it's fixed now.

@afc163 afc163 merged commit cba1533 into ant-design:master Apr 24, 2024
61 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。

@akinocccc akinocccc deleted the fix/badge-text-center branch April 24, 2024 06:14
@vagusX vagusX mentioned this pull request Apr 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badge 数字没有居中
2 participants
@akinocccc @afc163