Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎅 About the Christmas egg and workaround #13849

Closed
afc163 opened this issue Dec 25, 2018 · 63 comments
Closed

🎅 About the Christmas egg and workaround #13849

afc163 opened this issue Dec 25, 2018 · 63 comments

Comments

@afc163
Copy link
Member

afc163 commented Dec 25, 2018 •
edited

About the christmas egg in antd, it is derived from my commit 00aebeb at Sep 10th. This implementation will make primary button snowy with native tooltip Ho Ho Ho! at the specificed day of Dec 25th. It is a complete stupid decision of my own and very sorry to everyone that get involved.

How it

Versions would be affected: 3.9.3、3.10.0 ~ 3.10.9、3.11.0 ~ 3.11.5

We reverted the related commit and release patches: 3.9.4 3.10.10 3.11.6 you can upgrade to. If you are using semver version, reinstall node_modules would be ok.

Are there other eggs in antd's code.

No.

Are there same events would happen in future?

No, I promise. We are open source project, please supervise us like this time, like always.
@afc163 afc163 pinned this issue Dec 25, 2018
@alwaysloseall
Copy link
Contributor

Be careful next time.bro

@zephyrleaves
Copy link

zephyrleaves commented Dec 25, 2018 •
edited

pity boy

"projest" is project , be relax

@LeeYunhang
Copy link

LeeYunhang commented Dec 25, 2018 •
edited

AntDesign should not add feature to original components without developer's agree not only Christmas egg. :(

@xiaoxiaoting
Copy link

pity boy

"projest" is project , be relax

哈哈哈哈哈哈

@afc163 afc163 changed the title About the Chrismas egg and workaround 🎅 About the Chrismas egg and workaround Dec 25, 2018
@CupNoodleFork
Copy link

老哥你 christmas 还是拼错了。

@dengkunli
Copy link

chrismas -> christmas
decesion -> decision
of my owner -> of my own
projest -> project

and there're too many grammar errors as well...

@Riadloc
Copy link

Riadloc commented Dec 25, 2018

chrismas -> christmas
decesion -> decision
of my owner -> of my own
projest -> project

and there're too many grammar errors as well...

Are you 秀儿?

@Ragzzy-R
Copy link

our UAT push yesterday got postponed because of this as our client is not a christmas-ish person and we dont want to piss him off. Antd is supposed to be an enterprise UI solution please prevent such things in future or atleast give a headsup. Although! we love u guys! and all the time you help us save. so cheers! and Merry Christmas 👍

@lloydsheng
Copy link

作者太紧张了，写了很多语法错误。大家还是手下留情，先把问题解决掉 😂

@gztchan
Copy link

gztchan commented Dec 25, 2018

Merry Christmas 🎅🏻Just upgrade the library and let it go, guys!

@zclaiqcc
Copy link

Surprise!

@zmofei
Copy link

zmofei commented Dec 25, 2018

A good library, just because of a Christmas egg, sympathy.

@gitchennan
Copy link

写这个代码的人真的很没有水准，靠这种方式博人眼球，不配作为程序员，简直是丢阿里的脸

@fireflyhoo
Copy link

Be in awe of Allah

@zhansingsong
Copy link

zhansingsong commented Dec 25, 2018 •
edited

take it easy! big bro, not a big deal.
BTW, Recommend a grammar and spell checker for you, a chrome plugin: Grammarly for Chrome。

@shawn-msft
Copy link

I think you could fix your typos first...

@devnkong
Copy link

No offense bro, but you really need to correct your typos. I think some extensions may be helpful, like Grammarly.

@12Tall
Copy link

12Tall commented Dec 25, 2018

老哥你 christmas 还是拼错了。

哈哈哈哈哈哈哈哈哈哈哈哈哈哈哈哈

@afc163 afc163 changed the title 🎅 About the Chrismas egg and workaround 🎅 About the Christmas egg and workaround Dec 25, 2018
@latifrons
Copy link

Should I submit a pull request to fix your grammar and typo.

my commit 00aebeb [on] Sep 10th
happend -> happened
It is a complete stupid decesion of my owner and very sorry to everyone that get involved. [No. "decesion" is not sorry, you are sorry. And you should always SAY sorry to someone.]
Are there -> Will there be
We are open source projest [No you are not open source nor projest, your project antd is]

@ZJM6658
Copy link

ZJM6658 commented Dec 25, 2018

在这个寒冷的冬天，感受到了一丝暖意，我先回家过年了

@c0ming
Copy link

c0ming commented Dec 25, 2018

大家愤怒的是一种被强奸的感觉

@SergeyVolynkin
Copy link

Yeah, imagine getting that on production in some serious Bank! >.<

@heeeeeng
Copy link

Hahahahahaha.
Solve the problem, and Merry Christmas!

@FurshawFu
Copy link

在这个寒冷的冬天，感受到了一丝暖意，我先回家过年了
you such a PPXIA

@Xuralyon
Copy link

写这个代码的人真的很没有水准，靠这种方式博人眼球，不配作为程序员，简直是丢阿里的脸

麻烦别把娱乐圈式吐槽带到这里来

@silentred
Copy link

chrismas -> christmas
decesion -> decision
of my owner -> of my own
projest -> project

and there're too many grammar errors as well...

What a horrible catastrophe it is.

@zssjz
Copy link

zssjz commented Dec 25, 2018

事已至此，无论怎么表达愤怒都不能挽回损失；作为antd的使用者，我也对造成的后果感到惋惜，对过激的言论表示寒心；我还是希望antd能继续推出好的产品，也希望作者不要因为圣诞节事件有什么太多的负面影响；但还是希望今后能多方考虑后果，为广大开发者带来眼前一亮的作品。

@joesonw
Copy link
Contributor

joesonw commented Dec 25, 2018

take an easy! big bro, not a big deal.
BTW, Recommend a grammar and spell checker for you, a chrome plugin: Grammarly for Chrome。

take an easy -> take it easy
big bro -> bro
not a big deal -> it's not a big deal
Recommend -> I recommend

这插件也不咋地嘛

@wellenzhong
Copy link

Foreign friends are much friendlier than our Chinese guys.
anyway, thank you guys for your hard work!

@iwasa-kosui
Copy link

Hmm, I think that this page is not an English classroom...
How about focusing our eyes on codes and features?

@flyfox11
Copy link

flyfox11 commented Dec 25, 2018 •
edited

圣诞按钮一朵云，菜鸟落进了聊天群，满屏都是程序汉，谁修bug谁丢魂

@252405649
Copy link

写这个代码的人真的很没有水准，靠这种方式博人眼球，不配作为程序员，简直是丢阿里的脸

可能你不是程序员，才可以说出这样的话。小错，改了就好

@kangkai124
Copy link

老哥你 christmas 还是拼错了。
你是魔鬼吗...

@Zheaoli
Copy link

Zheaoli commented Dec 25, 2018

认真的说，这次最坏的情况下，有使用者被劝退是最好的结果
最坏的结果是有使用者被检察院以渎职罪或者破坏信息系统罪提起刑事诉讼了

@zhansingsong
Copy link

take an easy! big bro, not a big deal.
BTW, Recommend a grammar and spell checker for you, a chrome plugin: Grammarly for Chrome。

take an easy 是啥意思，歇息一下？take it easy
big bro 是另起一句了，应该是 Big bro, ...
Recommend 句内，不应该大写首字母吧
你用了这个插件没

哈哈，尴尬鸟。完整功能需要付费，穷屌丝一枚😆。不过插件整体体验还是不错的。

@0xinhua
Copy link

0xinhua commented Dec 25, 2018

chrismas -> christmas
decesion -> decision
of my owner -> of my own
projest -> project

and there're too many grammar errors as well...

Grammarly is a good tool for making sure everything you typed is right.

@GabrielCheung128
Copy link

Didn't upgrade to the corresponding version, so wasn't impacted by this.
But how could that be merged if it was only your decision? And how you responded to those who raised the issue first was quite ridiculous as well as offensive.
You guys should take it serious on code review, or somebody somewhere in the world would lose his job, that's NOT FUN at all.

Still, Merry Christmas.

@Lilysunstrider
Copy link

Es Yotube tod us: if yo rite anysing un yor coputer, yo ned Gramarly. Marry Chrismas!

@zhenghangjie
Copy link
Contributor

reverence for this issue

@ipv4sec
Copy link

ipv4sec commented Dec 25, 2018

惊闻 antd 发生了 圣诞节彩蛋事件，赶紧去检查了一遍所有项目，还好版本都较低没有发生故障，去官网观摩了一下，button 上的云彩的确够惊艳，说到云彩，我就想起筋斗云和孙悟空，明年年初，中美合拍的西游记即将正式开机，我继续扮演美猴王孙悟空，我会用美猴王艺术形象努力创造一个正能量的形象，文体两开花，弘扬中华文化，希望大家多多关注。

@JunYang-tes
Copy link

后排吃瓜。

@devcui
Copy link

devcui commented Dec 25, 2018 •
edited

后排偷偷卖片儿...加微信xxxxx
I'm in the back row to sell some dvd of sexxxxx~~~

@hunterhug
Copy link

hunterhug commented Dec 25, 2018 •
edited

I want to see that egg, can anyone tell me where.....

pity egg~~~

@Albuseven
Copy link

I want to see that egg, can anyone tell me where .....

https://mobile.ant.design/

@hunterhug
Copy link

I want to see that egg, can anyone tell me where .....

https://mobile.ant.design/

Ho HO HO~~~

@Gongziyu666
Copy link

换地方围观？

@edward-tes
Copy link

This egg is so big and so round.

@feichangtutu
Copy link

Are there same events happend in future?
是个病句啊……

@lzfgnu
Copy link

lzfgnu commented Dec 25, 2018

惊闻 antd 发生了 圣诞节彩蛋事件，赶紧去检查了一遍所有项目，还好版本都较低没有发生故障，去官网观摩了一下，button 上的云彩的确够惊艳，说到云彩，我就想起筋斗云和孙悟空，明年年初，中美合拍的西游记即将正式开机，我继续扮演美猴王孙悟空，我会用美猴王艺术形象努力创造一个正能量的形象，文体两开花，弘扬中华文化，希望大家多多关注。

谢罪吧，老哥

@bbbang007
Copy link

bbbang007 commented Dec 25, 2018 •
edited

are You gAys ookkk ???

@devcui
Copy link

devcui commented Dec 25, 2018

惊闻 antd 发生了 圣诞节彩蛋事件，赶紧去检查了一遍所有项目，还好版本都较低没有发生故障，去官网观摩了一下，button 上的云彩的确够惊艳，说到云彩，我就想起筋斗云和孙悟空，明年年初，中美合拍的西游记即将正式开机，我继续扮演美猴王孙悟空，我会用美猴王艺术形象努力创造一个正能量的形象，文体两开花，弘扬中华文化，希望大家多多关注。

向全国人民谢罪吧

@FurshawFu
Copy link

@afc163 麻烦关闭一下，这一下午垃圾邮件已经够多了。

@rootkiter
Copy link

Good job!

@afc163 afc163 mentioned this issue Dec 25, 2018
Closed
@ant-design ant-design locked and limited conversation to collaborators Dec 25, 2018
@afc163 afc163 closed this as completed Dec 26, 2018
@afc163 afc163 unpinned this issue Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests