Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

请也为春节加上彩蛋!我很喜欢ant design,感谢你们! #13847

Closed
1 task
full-stop opened this issue Dec 25, 2018 · 10 comments
Closed
1 task

请也为春节加上彩蛋!我很喜欢ant design,感谢你们! #13847

full-stop opened this issue Dec 25, 2018 · 10 comments

Comments

@full-stop
Copy link

full-stop commented Dec 25, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

更加人性化的 antd

What does the proposed API look like?

在配置文件中可以进行配置是否开启

@yutingzhao1991
Copy link
Contributor

+1

彩蛋的本意是好的,我觉得把彩蛋弄成主动配置的,加上春节这些更丰富的元素供选择,我想这未尝不可~

@wang007
Copy link

wang007 commented Dec 25, 2018

surprise!!!

@AkiyamaMinami
Copy link

对的,要是彩蛋能主动配置还是不错的,开发者改都不能改太蠢了...

@afc163
Copy link
Member

afc163 commented Dec 25, 2018

#13848

@afc163 afc163 closed this as completed Dec 25, 2018
@vianvio
Copy link

vianvio commented Dec 25, 2018

下回还是放console吧,这样更有彩蛋的感觉,彩蛋是要让人找的,所有人都看到就不算了

@huang-shi
Copy link

surprise!!!

surprise mother fxxker!

@fwh1990
Copy link

fwh1990 commented Dec 25, 2018

希望搞些彩蛋在开发环境。节日主题之类的,因为我在家随时都会写代码,即使是过年。

@zhegexiaohuozi
Copy link

挺好的呀,哈哈!

@rockallite
Copy link

rockallite commented Dec 26, 2018

In computer software and media, an Easter egg is an intentional inside joke, hidden message or image, or secret feature of a work.

Reference: Wikipedia

Publicly exposed UI elements are a part of a theme, not an Easter egg. And a theme should be totally configurable by developers. It shouldn't be secretly uncontrollably activated by the library itself.

However, ant-design is an MIT thing anyway. Legally I can blame library authors for nothing. Instead, I should be responsible for the messy things happend on Christmas day, because I am the one who chose to embed a specific open-source library in my own projects.

But that doesn't stop me from losing trust in the ant-design project.

@rockallite
Copy link

Ant-design developers, please read this blog post carefully:
https://blogs.msdn.microsoft.com/larryosterman/2005/10/21/why-no-easter-eggs/

There is nothing new under the sun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants