New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider tooltip in modal scrolling with page #13418
Comments
This may help you. |
Where would i add this piece of code so that it makes these changes to the slider tooltip? |
My fault, I confusion between |
|
So how would I add this ability to the tooltip code?
…On Mon, Dec 3, 2018, 10:08 PM orzorzorzorz ***@***.*** wrote:
getPopupContainer is used in Tooltip, but Slider didn't pass rest
attributes of props, maybe add them there
<https://github.com/ant-design/ant-design/blob/master/components/slider/index.tsx#L93>
?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13418 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AmxQD6T_5Eg3wi-TyNEku8a9KvPut-hlks5u1ecqgaJpZM4Y_puL>
.
|
Since the Tooltip is wrapped inside the slider and you cannot pass the
This will fix your issue with the current version, BTW we should add another prop to |
@afc163 , I think the prop should be added as optional prop, to avoid such issues. If yes, I can raise a PR. |
Thanks, I was playing around with the temporary solution. It works great for desktop screens, but I noticed for mobile screens the |
@issuehuntfest has funded $20.00 to this issue. See it on IssueHunt |
This is still occurring for me |
@dooleyb1 Please feel free to open a new issue. |
Hey, my fix to the solution was to add this prop to the Slider
Should work correctly with that. |
That worked perfectly, thank you! |
Version
3.11.0
Environment
Windows 10
Reproduction link
Steps to reproduce
Create a modal, make height larger then screen size so you are able to scroll,
create a slider with the tool tip always visible,
scroll
What is expected?
The slider tooltip should stay above the slider handle when you scroll
What is actually happening?
The tooltip is moving down the page as well when you scroll.
The text was updated successfully, but these errors were encountered: