New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎄 Christmas easter egg 🎄 #13098
Comments
You can override the css : ) .ant-btn.ant-btn-primary.christmas:before {
display: none!important;
} |
This might be ok for such a widely used application if it was at least opt-in... I cannot use this library professionally with this applied, and it is unfortunate that I had to scour source code to find it... |
Are there any other Easter eggs like this within Ant? I want to be sure I'm overriding them in my application. |
I really want to use Ant for future projects but decisions like this concern me. I imagine some poor developers are going to have their Christmas day interrupted when they get an angry email from their managers asking to remove the snow from all the buttons. |
it's not fun at all... at least there should be some config to disable it, not override the style!!! |
<ConfigProvider snowyButton={true}>
...
</ConfigProvider> Also, Merry Christmas to everybody~ 🤶🏻 Removed the egg in |
I would not recommend overriding CSS. All buttons come with "Ho ho ho!" title. If you remove the snow, title will pop up when you hover on the button. And it cannot be removed with CSS. You'll need to edit DOM. At least with the snow it will be more obvious that it's an easter egg and more acceptable for users than a normal button with "Ho ho ho!" title. |
Easter egg should be disabled by default in production mode. |
怎么去除 |
我们是做2B应用的,这种“彩蛋”让人有失控的感觉。翻了下过去的release里也没有提到过这个彩蛋,看起来是故意为之。但用户如果有意见,我们就被动了。加彩蛋可以,但最好控制权还是在开发者手里,默认关闭,由开发者决定是否开启。开发者给最终使用者的惊喜叫“彩蛋”,框架给开发者的惊喜就是惊吓了…… |
So foolish!!! |
💔 |
吓我一跳,没有 任何 说明 突然 来这么一下 |
This is ridiculous! We are running serious business using Ant.Design. If Ant.Design is designed as "library", how and when to present an Easter egg should be controlled by the application developer, not the library. Christmas is a happy day, but not for every business. |
吓死宝宝了! |
所谓“彩蛋”就是不会事先通知的。 我觉得雪花如果使用能够使用更高融合度的设计,也许更多人能一笑置之,毕竟没有什么不良影响。或许还能获得好评,毕竟skin这个概念是有的。可惜现在扁平的界面里那块3D雪。。。 |
前排围观 |
大家可以直接回滚到 3.9.2 之前。。。 @afc163 |
坐等好戏 |
不敢想象4.1日会出现什么! |
春节会不会来串鞭炮 |
我还觉得挺可爱····竟然大多数人不喜欢 ·。·看来这种规模的库还是要首先考虑用户的下限,然后再锦上添花 |
来瞧一瞧看一看了~~~欢迎各位有前端技术热情的同学加入我们。特别地,我们不会因为一个彩蛋就杀了程序员祭天。。。base 广州,上市公司。广招前端后台~~~有兴趣邮件一下简历谢谢~~~ |
这波招聘厉害了 |
不敢想象4.1日会出现什么! |
Merry Christmas! |
优秀啊 |
大版本4.x.x升级不会给我们一个很大很大的惊喜吧!!!!!????? |
这种彩蛋到底是要给客户带来"惊喜",还是给开发者带来惊吓? |
弄个投票,我投赞成票! |
坐等吃瓜 |
真是没一点责任心 不考虑用户使用场景 |
伊斯兰国家过圣诞节吗?打开一看十字军占领自己家网站了?前端被砍死有人负责吗? |
侵犯我们无神论者的信仰自由 |
这代码怎么加上去的? |
这波操作很溜,还好我们线上版本没更新,尴尬😓 |
What about the Spring Festival? Nothing in the Spring Festival? 春节呢?春节没有嘛??? |
Issue 是用来提问题跟解决问题,而不是用来炒热点的,讨论到这份上只能锁了 Issue is used to raise and solve problems, not to stir up hot spots, I lock this. |
What problem does this feature solve?
Christmas easter egg is a really fun joke, but in business app we should give the possibilities to switch off that. This feature could block users from using this awesome library
What does the proposed API look like?
My proposal is a prop (also true by default) and when switched to false it block the easter egg.
The text was updated successfully, but these errors were encountered: