Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] ConnectModal QRCode overflow #679

Closed
yutingzhao1991 opened this issue Mar 22, 2024 · 3 comments · Fixed by #848
Closed

[Bug] ConnectModal QRCode overflow #679

yutingzhao1991 opened this issue Mar 22, 2024 · 3 comments · Fixed by #848
Assignees
@thinkasany
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@yutingzhao1991
Copy link
Collaborator

What happens?

窗口比较小的时候二维码可能会溢出，应该保障尽量的适应屏幕宽度：

image image

How To Reproduce

Open https://web3.ant.design/~demos/connect-modal-demo-basic
Open WalletConnect QRcode
resize window width

Context

  • Ant Design Web3 Version:
  • Node Version:
  • Platform:
@yutingzhao1991 yutingzhao1991 added bug Something isn't working help wanted Extra attention is needed labels Mar 22, 2024
@thinkasany thinkasany self-assigned this Mar 22, 2024
@thinkasany
Copy link
Collaborator

试了一下用 '100%' 应该可以解决， 我先去隔壁蹭个pr， 不然这边代码提示是红的。

20240322150028_rec_
image
image

@thinkasany thinkasany mentioned this issue Mar 25, 2024
Merged
@thinkasany
Copy link
Collaborator

可能还得在等一版本，目前这版的antd qrcode只是把style的width透到了div的style中，svg的witdth还得做个合并，我再去沟通沟通。

image

@thinkasany thinkasany mentioned this issue Mar 31, 2024
Merged
20 tasks
@thinkasany
Copy link
Collaborator

wait for ant-design/ant-design#48194

This was referenced May 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thinkasany thinkasany

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ConnectModal QRCode overflow thinkasany/ant-design-web3
2 participants
@yutingzhao1991 @thinkasany