Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more wallet #399

Open
yutingzhao1991 opened this issue Dec 26, 2023 · 6 comments
Open

Support more wallet #399

yutingzhao1991 opened this issue Dec 26, 2023 · 6 comments
Assignees
@Likang0122
Labels
feature Independent new features help wanted Extra attention is needed

Comments

@yutingzhao1991
Copy link
Collaborator

Such like: TokenPocket, ImToken etc...
@yutingzhao1991 yutingzhao1991 added feature Independent new features help wanted Extra attention is needed labels Dec 26, 2023
@Likang0122
Copy link
Collaborator

Does it mean creating more in this folder

/packages/assets/src/wallets

@yutingzhao1991
Copy link
Collaborator Author

Does it mean creating more in this folder

/packages/assets/src/wallets

and packages/wagmi/src/wallets

@yutingzhao1991
Copy link
Collaborator Author

/packages/assets/src/wallets directory contains the fundamental information about wallets, and it includes wallet information for any blockchain.

packages/wagmi/src/wallets directory contains the WalletFactory that has been adapted for Ethereum, based on wagmi, and is used to construct a Wallet.

You can start by adding the basic information in /packages/assets/src/wallets. As for the implementation of WalletFactory in wagmi, it needs to be thought through carefully.

/packages/assets/src/wallets 这个里面是钱包的基础信息，不管什么链的钱包信息都写在里面。

packages/wagmi/src/wallets 这个里面是适配以太坊后基于 wagmi 扩展的 WalletFactory，用于构造出 Wallet。

可以先补充 /packages/assets/src/wallets 里面的基础信息，至于 wagmi 中的 WalletFactory 如何实现还要再好好想一下。

@Likang0122
Copy link
Collaborator

我来收集这些信息吧，TP, ImToken, OKX

@Likang0122 Likang0122 self-assigned this Dec 27, 2023
@yutingzhao1991
Copy link
Collaborator Author

For support more wallet with WalletConnect, I have a idea about it: #414

@yutingzhao1991
Copy link
Collaborator Author

#455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Likang0122 Likang0122

Labels
feature Independent new features help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yutingzhao1991 @Likang0122