Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address display type should be checksum not only lowercase #373

Open
lxhyl opened this issue Dec 23, 2023 · 3 comments
Open

Address display type should be checksum not only lowercase #373

lxhyl opened this issue Dec 23, 2023 · 3 comments

Comments

@lxhyl
Copy link

lxhyl commented Dec 23, 2023

Generally checksum is use to display Ethereum address in dApp. Like most popular dApp like UniSwap, Balancer, GMX...

There have a article to explain why Checksum is necessary.

https://medium.com/coinmonks/ethereum-checksummed-addresses-importance-and-implementation-eef74aa3ae18

@yutingzhao1991
Copy link
Collaborator

yutingzhao1991 commented Dec 23, 2023

Good suggestion, how about add a new prop `checksum` for it?

When checksum is true, check address and show error when address is not correct.

@lxhyl
Copy link
Author

lxhyl commented Dec 26, 2023

Cool. And i'm happy to do this if you don't have the time

@yutingzhao1991
Copy link
Collaborator

Cool. And i'm happy to do this if you don't have the time

Of course, you're welcome, but how to reflect the situation of an incorrect address in terms of style may require design support, which we can discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants