Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing the ap_opt() #472

Open
rpf5573 opened this issue Jun 6, 2018 · 3 comments
Open

Confusing the ap_opt() #472

rpf5573 opened this issue Jun 6, 2018 · 3 comments

Comments

@rpf5573
Copy link
Contributor

rpf5573 commented Jun 6, 2018

ap_opt( 'categoreis_page' ) => 1951
ap_opt( 'categories_page_id' ) => categories

I think this is a little confusing.
And in ap_create_base_page(),

ap_opt( $slug, $page->ID );
ap_opt( $slug . '_id', $page->post_name );

I think we should change this code. But, I don't know what is more good way, because ap_opt() is used in may place! It will be more safe for you to change this code.

Check please!

@rahularyan
Copy link
Member

Yes, you are right. This need to be changed. This function is there in AnsPress since initial release and used in many places.
Need to wait for a major release to fix this. Thanks for reporting.

@cema93
Copy link
Contributor

cema93 commented May 21, 2024

seems fixed?

@rahularyan
Copy link
Member

Hi @cema93
No this is still not updated. But it will be updated on next major release which I am already working on. You can track current changes here: master...remove-deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants