Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui_next] Schedules, values for 'FrequencyDetailSubform__RunEveryLabel' and 'Detail__DetailName: Repeat Frequency', needs to be marked for translations #6858

Open
sshedmake opened this issue Apr 28, 2020 · 4 comments
Labels
component:l10n localization, translation, japanese, french component:ui type:bug

Comments

@sshedmake
Copy link

ISSUE TYPE
  • Bug Report
SUMMARY

With Japanese (dummy translation) google-chrome, values for 'FrequencyDetailSubform__RunEveryLabel' and 'Detail__DetailName: Repeat Frequency', at 'Templates > JT > Schedules > {Edit and Schedule} Details' screen, appears in English (instead of Japanese)

ENVIRONMENT
  • AWX version: 10.0.0
  • AWX install method: docker on linux
  • Ansible version: 2.10.0.dev0
  • Operating System: Fedora 31
  • Web Browser: google-chrome
STEPS TO REPRODUCE
  1. Do a successful login to the ui_next interface in the preferred language (say Japanese)
  2. Navigate to breadcrumb 'Templates > Demo Job Template > Schedules > Run Demo JT 5 Times > {Edit and Schedule} Details'
  3. Observe respective values for 'FrequencyDetailSubform__RunEveryLabel' and 'Detail__DetailName: Repeat Frequency'
EXPECTED RESULTS

Content should appear in Japanese

ACTUAL RESULTS
  1. 'weeks' | 'months'

  2. 'Every week on Monday, Wednesday, Friday for 5 times' | 'Every month on Monday, Tuesday, Wednesday, Thursday, Friday, Saturday, Sunday until October 27, 2020'

ADDITIONAL INFORMATION
  1. Screenshot higlighting respective values for 'FrequencyDetailSubform__RunEveryLabel' and 'Detail__DetailName: Repeat Frequency', appearing in English, with Japanese google-chrome:

Run every 1 months:
output_months

Run every 1 weeks:
output_weeks

@wenottingham wenottingham added component:l10n localization, translation, japanese, french component:ui_next labels Apr 30, 2020
@nixocio nixocio self-assigned this May 5, 2020
@nixocio
Copy link
Contributor

nixocio commented Oct 9, 2020

The string for Repeat Frequency is dynamically generated and comes from RRule . After talking with @mabashian about it, we came up with a few possible solutions.

1 - Always show as an English.
2 - Custom translation issue - See: jkbrzt/rrule#13
3 - Hide the field Repeat Frequency if the browser language is not English.
4 - Remove the field - Repeat Frequency, since the info is already present with UI Occurrences.

@trahman73 @wenottingham @sshedmake thoughts?

@mabashian
Copy link
Member

Some more information about this field: #6173

@mabashian
Copy link
Member

Enhancement here would be to have this string translated (maybe we roll our own implementation of it?) but we plan on leaving that field for now.

@nixocio nixocio removed their assignment Jun 28, 2021
@sshedmake
Copy link
Author

Added @Spredzy here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:l10n localization, translation, japanese, french component:ui type:bug
Projects
None yet
Development

No branches or pull requests

7 participants