-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-py version is checked incorrectly #17495
Comments
See also docker/docker-py#1200 (comment) |
Confirmed, Debian Jessie. Seems...urgent. |
Note that docker-compose 1.8.0 requires docker-py >1.9,<2.0, so if you're specifically setting docker-py to a version lower than 1.9.0 and installing docker-compose 1.8.0 it will upgrade docker-py all the way to 1.10.1 which presently breaks the string version comparison. Set docker-py to 1.9.0 prevent this. |
Most people using the normal galaxy package for docker will be getting the On Fri, Sep 9, 2016, 7:09 PM Shane StClair notifications@github.com wrote:
|
FWIW, I'm not setting docker-py to any specific version and this broke me anyway. |
Yup, I can confirm it on Ubuntu 16.04. |
Does a temporary workaround exist? |
A downgrade of docker-py to 1.9.0 is probably the easiest On Mon, Sep 12, 2016, 7:59 AM Kevin Wittek notifications@github.com wrote:
|
@kiview |
@vietbui Thanks, even worked by specifying a specific |
Hello guys, when are you going to release a new version with this change merged? Are you planning to do it soon? Thanks! |
Facing this issue as well Downgraded docker-py as suggested by @vietbui and it's working!
|
I thought this would be fixed in 2.1.2.0 but I tried today: This is, in my opinion, an urgent problem! |
This change has been backported to stable-2.1 for 2.1.3RC3. Will backport to stable-2.2 if there's another 2.2.0 release candidate, otherwise, it should be in for 2.2.1. |
nice @nitzmahone, exactly what most of us are looking for 👍 |
👍 |
... aaand there's going to be a 2.2.0RC4, so this one's been cherry-picked to go along for the ride. |
+1 |
Looks like ansible 2.2.0 is out, which fixes this issue. Right? |
Yeah, and 2.2 seems to break |
Right
|
It's honestly awe-striking how fragile ansible is as an environment and the amount of effort it demands its users for keeping basic functionalities working with just a minor upgrade. Remarkable. |
Not able to verify fix in Ansible 2.2 as it breaks for another reason on Mac OS X:
|
Because this ticket is closed, no one is likely to see comments on it. Please open a new ticket if you are having issues. @darkn3rd -- it looks like your problem is an incompatibility between the docker_common.py command and python3 on the managed machine. Workaround would be to run with python2. I'll look at making a PR for the python3 problem. |
Should fix the error reported here: ansible#17495 (comment)
Should fix the error reported here: #17495 (comment)
Should fix the error reported here: #17495 (comment) (cherry picked from commit 4f960a4)
We must specify the version of "docker-py" explicitly to workaround the following ansible issue: ansible/ansible#17495
probably lowering ansible version raised this bug: ansible/ansible#17495
ISSUE TYPE
COMPONENT NAME
docker integration (but not the docker module) (https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/docker_common.py#L154)
ANSIBLE VERSION
CONFIGURATION
None
OS / ENVIRONMENT
OS X, El Cap
SUMMARY
docker-py just bumped its version to
1.10
. This is the code that checks the version:This is how python compares strings:
STEPS TO REPRODUCE
EXPECTED RESULTS
Run docker
ACTUAL RESULTS
The text was updated successfully, but these errors were encountered: