Problem with handlers when reusing role in playbook #15084
Comments
|
I may have fixed this recently, but I'll look into it as soon as I can. |
|
This is still same with Ansible 2.1
But it stops container with name that has been defined as very first in playbook. I tried to use variable in handler's name but they are not triggered at all in that case. Update: and this in playbook |
jimi-c
added a commit
that referenced
this issue
Jun 13, 2016
Due to the fact that roles may be instantiated with different sets of params (multiple inclusions of the same role or via role dependencies), simply tracking notified handlers by name does not work. This patch changes the way we track handler notifications by using the handler object itself instead of just the name, allowing for multiple internal instances. Normally this would be bad, but we also modify the way we search for handlers by first looking at the notifying tasks dependency chain (ensuring that roles find their own handlers first) and then at the main list of handlers, using the first match it finds. This patch also modifies the way we setup the internal list of handlers, which should allow us to correctly identify if a notified handler exists more easily. Fixes #15084
jimi-c
added a commit
that referenced
this issue
Jun 13, 2016
Due to the fact that roles may be instantiated with different sets of params (multiple inclusions of the same role or via role dependencies), simply tracking notified handlers by name does not work. This patch changes the way we track handler notifications by using the handler object itself instead of just the name, allowing for multiple internal instances. Normally this would be bad, but we also modify the way we search for handlers by first looking at the notifying tasks dependency chain (ensuring that roles find their own handlers first) and then at the main list of handlers, using the first match it finds. This patch also modifies the way we setup the internal list of handlers, which should allow us to correctly identify if a notified handler exists more easily. Fixes #15084
jimi-c
added a commit
that referenced
this issue
Jun 14, 2016
Due to the fact that roles may be instantiated with different sets of params (multiple inclusions of the same role or via role dependencies), simply tracking notified handlers by name does not work. This patch changes the way we track handler notifications by using the handler object itself instead of just the name, allowing for multiple internal instances. Normally this would be bad, but we also modify the way we search for handlers by first looking at the notifying tasks dependency chain (ensuring that roles find their own handlers first) and then at the main list of handlers, using the first match it finds. This patch also modifies the way we setup the internal list of handlers, which should allow us to correctly identify if a notified handler exists more easily. Fixes #15084
jimi-c
added a commit
that referenced
this issue
Jun 15, 2016
Due to the fact that roles may be instantiated with different sets of params (multiple inclusions of the same role or via role dependencies), simply tracking notified handlers by name does not work. This patch changes the way we track handler notifications by using the handler object itself instead of just the name, allowing for multiple internal instances. Normally this would be bad, but we also modify the way we search for handlers by first looking at the notifying tasks dependency chain (ensuring that roles find their own handlers first) and then at the main list of handlers, using the first match it finds. This patch also modifies the way we setup the internal list of handlers, which should allow us to correctly identify if a notified handler exists more easily. Fixes #15084
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Issue Type:
Ansible Version:
Ansible Configuration:
n/a
Environment:
Running Ansible from Ubuntu 14.04
Managing OS: CentOS 7
Summary:
When reusing a role in playbook, a handler is not using expected role's variable value within the handler task.
(I'm not sure if it is the expected behavior or not. I'm suspecting that variables used in handlers are substituted when the handler is defined)
Steps To Reproduce:
Clone https://github.com/mickael-ange/ansible-reports and run:
Expected Results:
The second handler call would have
item=test2.Actual Results:
The actual result is that both handler calls use the same variable value (
item=test1) even if the variabletest_namehas been redefined in the playbook.The text was updated successfully, but these errors were encountered: