Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commands for community group and host VRF #795

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Fix commands for community group and host VRF #795

wants to merge 8 commits into from

Conversation

TheRealBecks
Copy link

@TheRealBecks TheRealBecks commented Dec 19, 2023 •
edited

draft

SUMMARY

Fixes #794

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_snmp_server

ADDITIONAL INFORMATION

I changed the community command logic to the user command logic, so I had to split it from community to community.groups and community.use_acls. Therefore also the data structure has to be changed what makes this PR incompatible with older versions:
https://github.com/ansible-collections/cisco.nxos/pull/795/files#diff-94d7a7b6fd06a67cd2fa5a720e80962f8b320dfe00016a8e3dc58bd4f8163abaR43-R66

I will also provide the changes needed for the host VRF.

❓ Do these changes match your expectations?

If yes then the following changes need to be made:

  • unit tests
  • integration tests
  • documentation
  • changelog

@github-actions GitHub Actions
Copy link

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@TheRealBecks TheRealBecks changed the title Fix community group command Fix commands for community group and host VRF Dec 19, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d8c7393c026e4344bc6c1cf7835921c3

✔️ ansible-galaxy-importer SUCCESS in 5m 42s
✔️ build-ansible-collection SUCCESS in 9m 59s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 32m 13s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario02 FAILURE in 28m 28s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 36m 26s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 58s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 FAILURE in 34m 30s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 FAILURE in 33m 25s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 FAILURE in 40m 24s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 31m 47s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 36m 03s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 FAILURE in 32m 32s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 FAILURE in 40m 08s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 31m 51s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 26s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ae0621baac584bb0b3519cb283d1eaf2

✔️ ansible-galaxy-importer SUCCESS in 4m 45s
✔️ build-ansible-collection SUCCESS in 9m 47s
❌ ansible-test-network-integration-nxos-cli-python39-scenario01 RETRY_LIMIT in 9m 18s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario02 FAILURE in 26m 48s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 35m 21s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 50s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 36m 08s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 FAILURE in 32m 17s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 FAILURE in 39m 38s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 41s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 SUCCESS in 36m 41s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 FAILURE in 32m 49s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 FAILURE in 42m 16s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 30m 56s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 34s

@NilashishC NilashishC self-requested a review December 20, 2023 06:01
@TheRealBecks TheRealBecks mentioned this pull request Feb 10, 2024
Open
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4eb1ec2adb404cfc971d0caeca940d1e

✔️ ansible-galaxy-importer SUCCESS in 4m 45s
✔️ build-ansible-collection SUCCESS in 10m 17s
❌ ansible-test-network-integration-nxos-cli-python39-scenario01 FAILURE in 29m 52s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario02 FAILURE in 27m 26s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 35m 50s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 28m 23s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 SUCCESS in 35m 19s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 FAILURE in 35m 15s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 44m 56s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 35m 06s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 FAILURE in 36m 29s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 FAILURE in 33m 38s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 42m 10s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 34m 19s (non-voting)
✔️ ansible-tox-linters SUCCESS in 12m 53s

@NilashishC NilashishC added the major This PR has breaking changes. label Mar 26, 2024
@TheRealBecks TheRealBecks mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NilashishC NilashishC Awaiting requested review from NilashishC

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
major This PR has breaking changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNMP: Wrong commands for community group and host VRF
2 participants
@TheRealBecks @NilashishC