You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The text was updated successfully, but these errors were encountered:
oleksandr-danylchenko
changed the title
Rename the unmount -> destroy in the Plugin cleanup callback
Rename the AnnotoriousPlugin cleanup callback unmount -> destroyFeb 26, 2024
Current State
Currently, the
AnnotoriousPluginProps
receives theplugin
function argument that returns the{ unmount: ... }
object:annotorious/packages/annotorious-react/src/AnnotoriousPlugin.tsx
Lines 5 to 11 in adc3f3b
Issue
Could we rename the
unmount
todestroy
? Seems like it's a more popular name for the cleanup within the library and is used for most of the modules:annotorious/packages/annotorious/src/Annotorious.ts
Lines 107 to 118 in adc3f3b
The text was updated successfully, but these errors were encountered: