Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require.js conflict [Bug] #570

Closed
iamsolarplexus opened this issue Aug 3, 2020 · 4 comments
Closed

Require.js conflict [Bug] #570

iamsolarplexus opened this issue Aug 3, 2020 · 4 comments
Labels
bug Bug report resolved

Comments

@iamsolarplexus
Copy link

Our software uses require.js, and it appears yours does as well. Since the update, we have seen an unexpected error in the console which is due to multiple instances of require.js trying to run our code.

Sadly, I can't help you repro the problem or give too many proprietary details about our code. Basically, we use a data-main attribute for our require.js script tag that runs a file to modify the require-base stuff. See here for more about that: https://requirejs.org/docs/api.html#data-main
Now that's happening twice and the second time incorrectly since it's running it as a relative path, tacking that main js file to the end of the url.

So perhaps the solution is for us to change our software to have more specificity about which require.js to use. But if you could contain the scope of your require.js a bit, as it was before (or is the addition of requirejs new?) that'd be ideal. I don't think we'll change soon, so I might just have to find another CSS extension if you can't change it.

To repro, create a little local site using the data-main attribute and see if it conflicts.

@ankit ankit added the bug Bug report label Aug 4, 2020
@ankit ankit added the fix in progress Prioritized and actively working on fixing this bug label Aug 5, 2020
@ankit
Copy link
Owner

ankit commented Aug 5, 2020

@iamsolarplexus thanks for reporting. I was redundantly injecting the requirejs script without the stylebot editor being activated. I am hoping this will resolve the issue. I will let you know when the release is published on the chrome webstore so you can help me test this out.

@ankit ankit added the in webstore review Release containing fix is in review in Chrome Web Store label Aug 5, 2020
@iamsolarplexus
Copy link
Author

I'm so glad it's an evident issue with a potential fix on the way. Thanks for your responsiveness. The recent changes to the UI look really good, btw.

I'll look forward to testing out the next release when you advise.

@ankit ankit removed the in webstore review Release containing fix is in review in Chrome Web Store label Aug 18, 2020
@ankit
Copy link
Owner

ankit commented Aug 18, 2020

@iamsolarplexus this should now be resolved in the latest update. Feel free to reopen this issue, if it isn't

@ankit ankit added resolved and removed fix in progress Prioritized and actively working on fixing this bug labels Aug 18, 2020
@ankit ankit closed this as completed Aug 18, 2020
@iamsolarplexus
Copy link
Author

Confirmed. Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report resolved
Projects
None yet
Development

No branches or pull requests

2 participants