Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currency and its symbol for each country #369

Open
dleohoorah opened this issue Dec 21, 2020 · 6 comments
Open

Add currency and its symbol for each country #369

dleohoorah opened this issue Dec 21, 2020 · 6 comments
Labels
conception Scope of the deck, memorisation, contribution guidelines, etc.

Comments

@dleohoorah
Copy link

That would be awesome.

@axelboc axelboc added better-deck-manager Improvements feasible with a better deck manager conception Scope of the deck, memorisation, contribution guidelines, etc. labels Dec 21, 2020
@VNDCK
Copy link

VNDCK commented Dec 23, 2020

Vouch for this one! Would be very usefull.

@ohare93
Copy link
Member

ohare93 commented Dec 23, 2020

This will never be done as a part of this deck 😓 "Add x/y/z field" is probably the most requested change to this deck (some from me!) and all have been turned down as it would require more maintenance.

However, hypothetically, if you could make your own extension repo to this one, which only contained a csv with the countries, their currency, and it's symbol (ignore the card templates for those questions and whatnot) would any of you happily maintain such a repo alongside this one? 😃

I ask because after #364 this may be possible 😉 Still a while off though, but just asking to see if the interest exists in you eager folks 😁

@dleohoorah
Copy link
Author

This will never be done as a part of this deck 😓 "Add x/y/z field" is probably the most requested change to this deck (some from me!) and all have been turned down as it would require more maintenance.

However, hypothetically, if you could make your own extension repo to this one, which only contained a csv with the countries, their currency, and it's symbol (ignore the card templates for those questions and whatnot) would any of you happily maintain such a repo alongside this one? 😃

I ask because after #364 this may be possible 😉 Still a while off though, but just asking to see if the interest exists in you eager folks 😁

I have made an Excel spreadsheet with what I could find on this Wikipedia page here: https://en.wikipedia.org/wiki/List_of_circulating_currencies

Is this what you described?

@VNDCK
Copy link

VNDCK commented Dec 24, 2020

That would be great! I Will have a look into that myself ;).

@dleohoorah
Copy link
Author

That would be great! I Will have a look into that myself ;).

The issue is that not all countries have their own money and I don't know how to incorporate these data into the main deck. And I don't know how to do repo or GitHub at all, as you see I only signed up to post this very request lol.

Gotta wait for someone more capable than myself to do it I guess.

@ohare93
Copy link
Member

ohare93 commented Dec 25, 2020

I have made an Excel spreadsheet with what I could find on this Wikipedia page here: https://en.wikipedia.org/wiki/List_of_circulating_currencies

Is this what you described?

Pretty much, yes. The general idea being that for the people who want extra parts to the deck, well they can add these extra fields without having to give up the ability to stay up to date with the latest UG 👍 the extension repo would only contain the extra information to be added (Currency for each country, in this case) in the same format as the original repo, using the same country names so that the data matches up. Then the main deck builds via Brain Brew and produces the normal deck (plus the Extended Deck) and you can run that same command inside the Currency Extension repo to produce the exact same deck + currency info.

@VNDCK

That would be great! I Will have a look into that myself ;).

@dleohoorah

The issue is that not all countries have their own money and I don't know how to incorporate these data into the main deck. And I don't know how to do repo or GitHub at all, as you see I only signed up to post this very request lol.

Gotta wait for someone more capable than myself to do it I guess.

The functionality is not ready, and the main deck has not been switched over to Brain Brew yet. But this is the general direction we hope to go, in order to allow for users like like you and I to have more freedom with this fantastic learning resource, without bogging it down too much 😁 I am glad to hear others want this too 😁 Those with no free time feel free to read this thread 😉

I will volunteer to do all the management to get the deck builder working as people desire 💪 as long as others provide and maintain the actual data itself 😁 Though day 1 I will be making an extension for IPA 😉 (See #81) I'll make a working version of that first, then let others here know the functionality is good to go 👍 no promises about the timeframe! 😆

@axelboc axelboc removed the better-deck-manager Improvements feasible with a better deck manager label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conception Scope of the deck, memorisation, contribution guidelines, etc.
Development

No branches or pull requests

4 participants