Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shikimori tracking anime - HTTP error 404 (+ example how to fix it) #1553

Open
8 tasks done
Froxim opened this issue Apr 25, 2024 · 5 comments
Open
8 tasks done

Shikimori tracking anime - HTTP error 404 (+ example how to fix it) #1553

Froxim opened this issue Apr 25, 2024 · 5 comments

Comments

@Froxim
Copy link

Froxim commented Apr 25, 2024

Steps to reproduce

  1. Anime should be added to the list on Shikimori
  2. Select this anime to track in the application
  3. API returns HTTP error 404

Expected behavior

Anime should start tracking without errors

Actual behavior

HTTP error 404

Crash logs

No response

Aniyomi version

0.15.2.4

Android version

Android 12

Device

Xiaomi Redmi Note 9 Pro

Other details

I examined the request creation code in the ShikimoriApi.kt file and discovered the cause of the error:
IMG_20240425_093443
If replace "mangas" with "animes" the tracking will work.
I checked it on a copy - HTTP error 404 no longer appeared.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with an official extension, I should be opening an issue in the extensions repository.
  • If this is an issue with an official manga extension and this issue can be replicated in the Tachiyomi app, that I should be opening an issue in Tachiyomi's extensions repository.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.15.2.4.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@Diehardboy1722
Copy link

Same problem and don't know how to solve.

@Froxim
Copy link
Author

Froxim commented May 8, 2024

I described the fix in Other details. But I've never used Github, and I don't know how to add it to the project. The screenshot shows the place in the code that needs to be replaced with "animes". This will solve the problem.
IMG_20240508_212856

@fakebhai
Copy link
Contributor

fakebhai commented May 8, 2024

I described the fix in Other details. But I've never used Github, and I don't know how to add it to the project. The screenshot shows the place in the code that needs to be replaced with "animes". This will solve the problem.

I tried to login my account today but password reset didn't work, I'll try again tomorrow and see if that change fixes it

@Froxim
Copy link
Author

Froxim commented May 9, 2024

I described the fix in Other details. But I've never used Github, and I don't know how to add it to the project. The screenshot shows the place in the code that needs to be replaced with "animes". This will solve the problem.

I tried to login my account today but password reset didn't work, I'll try again tomorrow and see if that change fixes it

You can create a temporary email for a test account on Shikimori. For example, https://temp-mail.org/ru/

@fakebhai
Copy link
Contributor

fakebhai commented May 9, 2024

You can create a temporary email for a test account on Shikimori. For example, https://temp-mail.org/ru/

no need, I already resolved it. I'll probably PR tomorrow. I fixed that and labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants