Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sortablejs peerDependency is bundled in dist output #24

Open
wopian opened this issue Jan 7, 2022 · 2 comments
Open

sortablejs peerDependency is bundled in dist output #24

wopian opened this issue Jan 7, 2022 · 2 comments

Comments

@wopian
Copy link

wopian commented Jan 7, 2022

sortablejs is bundled in all but the TypeScript type definition files in /dist (https://www.jsdelivr.com/package/npm/vue-draggable-next?path=dist)

This leaves us with a missing peer dependency warning if we do not add it (which is annoying, but fine as we don't use TypeScript) or 7 copies of sortablejs if we install the peer dependency (the package and 6 copies of whichever version is bundled in a vue-draggable-next release)

It also has the side effect of the type definitions not being in sync with the version of sortablejs being used by vue-draggable-next for TypeScript users.

Can sortablejs be added as a dependency (preferred) or unbundle the peerDependency so the install instructions become (yarn add vue-draggable-next sortablejs)?

@dmix
Copy link

dmix commented Jun 27, 2022

Screenshot 2022-06-27 at 5 59 21 PM

this is the warning for the latest version

@anish2690
Copy link
Owner

@wopian working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants