Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly update to postCSS v8 #1204

Open
eltonmesquita opened this issue Dec 31, 2020 · 13 comments
Open

Properly update to postCSS v8 #1204

eltonmesquita opened this issue Dec 31, 2020 · 13 comments

Comments

@eltonmesquita
Copy link
Collaborator

Recently we updated to postCSS v8 which brings lots of changes, including how to use it and its "plugins" as dependencies in the project. Right now the building system is working but it's throwing some warn as we're not following the recommendations.

We need to fix this and get #1194 merged so everything is working nicely and in the best way possible. Help is very welcomed!

@warengonzaga
Copy link
Member

I just pull the changes... and try to fix this.

@eltonmesquita
Copy link
Collaborator Author

@warengonzaga , shout out if you need any help on this, alright?

@warengonzaga
Copy link
Member

@warengonzaga , shout out if you need any help on this, alright?

I don't see any errors on compiling.

@eltonmesquita
Copy link
Collaborator Author

Work on #1194 branch and you can see the warnings. Also, if you read postCSS docs/migration guide you'll see that it doesn't use plugins anymore even though they are supported. A bit weird but makes sense with what they're doing now.

@eltonmesquita
Copy link
Collaborator Author

BTW, Happy New Year @warengonzaga 🍾 🥂 🎉 ! Thanks for all the effort you've put in the library!

@warengonzaga
Copy link
Member

BTW, Happy New Year @warengonzaga 🍾 🥂 🎉 ! Thanks for all the effort you've put in the library!

Happy New Year too! No problem... small effort.

@eltonmesquita eltonmesquita added this to To do in V5.0.0 Jul 20, 2021
@eltonmesquita
Copy link
Collaborator Author

postCSS and its "plugin" were updated on #1339. Now we just need to follow the migration guide to make sure we're using postCSS properly.

@sertaco
Copy link

sertaco commented Nov 6, 2021

Thumbs up!
Enjoying your lib immensely, great job. But animate.css is now blocking me from using tailwind because of the lack of PostCSS 8. Cheering for you for the release, it looks like it is almost there.

@warengonzaga
Copy link
Member

Thumbs up! Enjoying your lib immensely, great job. But animate.css is now blocking me from using tailwind because of the lack of PostCSS 8. Cheering for you for the release, it looks like it is almost there.

Hi @sertaco, we'll make sure that in our coming release the postCSS will be updated.

@eltonmesquita
Copy link
Collaborator Author

eltonmesquita commented Nov 8, 2021

@sertaco animate.css should work with tailwind no matter our postCSS version because we don't actually ship - anymore - anything related to postCSS. We only ship the minimal files needed (compiled and source CSS and package.json file). Could you detail your problem?

@sertaco
Copy link

sertaco commented Nov 12, 2021

Thanks @eltonmesquita for the explanation. my npm was complaining about animate's postcss dependency but after upgrading all packages in package.json and clean installing I do not have the error anymore. Not sure exactly why I was getting the error maybe an earlier version install remnants in lock.json. not sure but thanks, it works now.

@warengonzaga
Copy link
Member

Thanks @eltonmesquita for the explanation. my npm was complaining about animate's postcss dependency but after upgrading all packages in package.json and clean installing I do not have the error anymore. Not sure exactly why I was getting the error maybe an earlier version install remnants in lock.json. not sure but thanks, it works now.

If it is a Warning that's good, you can ignore it. If it is an error, then you have to do something.

@BeepBot99
Copy link

Can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
V5.0.0
To do
Development

No branches or pull requests

5 participants
@sertaco @eltonmesquita @warengonzaga @BeepBot99 and others