Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some HTML tags with semantic tags #5

Open
anilsenay opened this issue Oct 13, 2020 · 4 comments
Open

Replace some HTML tags with semantic tags #5

anilsenay opened this issue Oct 13, 2020 · 4 comments
Labels
future-plan Suggest a future plan help wanted Extra attention is needed

Comments

@anilsenay
Copy link
Owner

For a better a11y(Accessibility) some div tags must be replace with semantic tags.
@anilsenay anilsenay added help wanted Extra attention is needed future-plan Suggest a future plan labels Oct 13, 2020
@dudzpedra
Copy link

Hello! still need help with that? I'm studying the Nextjs Commerce template (by Vercel) and would love to contribute!

@anilsenay
Copy link
Owner Author

@dudzpedra Of course, thank you! I couldn't move the project forward for a while. So community support could be very helpful.

@dudzpedra
Copy link

Created a PR for some changes in index.js, hope you like it. Just getting started here =)

@dudzpedra
Copy link

Created a PR for some changes in index.js, hope you like it. Just getting started here =)

Deleted that PR because of the firebase information that shouldnt be out there.

I was thinking about maybe changing those tags to section tags

One section for the div.header and another one for the div.header buttons

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future-plan Suggest a future plan help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anilsenay @dudzpedra