Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension does not work after updating to Angular v8.1.0 #343

Closed
ramunas-k opened this issue Jul 4, 2019 · 11 comments · Fixed by #344
Closed

Extension does not work after updating to Angular v8.1.0 #343

ramunas-k opened this issue Jul 4, 2019 · 11 comments · Fixed by #344
Assignees

Comments

@ramunas-k
Copy link

ramunas-k commented Jul 4, 2019

I use this extension a lot, but today after updating to Angular v8.1.0 I noticed that I'm not getting any support from it. Here is the extension output:

Search path: /home/user/git/project/src/app/campaigns/campaign-list
Config file name: /home/user/git/project/tsconfig.json
Angular Language Service: 8.1.0
TypeScript: 3.4.5
SERVER ERROR: this.ngHost.setSite is not a function
TypeError: this.ngHost.setSite is not a function
    at new CompilerService (/home/user/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:1754:21)
    at new Project (/home/user/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:705:36)
    at ProjectService.createProject (/home/user/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:1726:23)
    at ProjectService.openConfigFile (/home/user/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:1629:28)
    at ProjectService.openOrUpdateConfiguredProjectForFile (/home/user/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:1489:41)
    at ProjectService.openClientFile (/home/user/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:1407:23)
    at /home/user/.vscode/extensions/angular.ng-template-0.800.0/server/documents.js:135:47
    at TextDocuments.logErrors (/home/user/.vscode/extensions/angular.ng-template-0.800.0/server/documents.js:235:13)
    at /home/user/.vscode/extensions/angular.ng-template-0.800.0/server/documents.js:131:74
    at handleNotification (/home/user/.vscode/extensions/angular.ng-template-0.800.0/server/node_modules/vscode-jsonrpc/lib/main.js:489:43)
[Error - 10:41:05 AM] Notification handler 'textDocument/didOpen' failed with message: this.ngHost.setSite is not a function

ng version output:

Angular CLI: 8.1.0
Node: 12.6.0
OS: linux x64
Angular: 8.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.801.0
@angular-devkit/build-angular     0.801.0
@angular-devkit/build-optimizer   0.801.0
@angular-devkit/build-webpack     0.801.0
@angular-devkit/core              8.1.0
@angular-devkit/schematics        8.1.0
@ngtools/webpack                  8.1.0
@schematics/angular               8.1.0
@schematics/update                0.801.0
rxjs                              6.5.2
typescript                        3.4.5
webpack                           4.35.2

Downgrading Angular back to v8.0.3 fixes the issue.

P.S. I have originally filed this issue as related to updating to VSCode 1.36, but it has nothing to do with it. VSCode 1.36 + Angular v8.0.3 this extensions works like a charm

@ramunas-k ramunas-k changed the title Extension does not work after VSCode update to v1.36 Extension does not work after updating to Angular v8.1.0 Jul 4, 2019
@marcopetreri
Copy link

marcopetreri commented Jul 4, 2019

Same problem, here are my outputs.

Angular Language Service

Config file name: /Users/marcopetreri/projects/***/tsconfig.json
Angular Language Service: 8.1.0
TypeScript: 3.4.5
SERVER ERROR: this.ngHost.setSite is not a function
TypeError: this.ngHost.setSite is not a function
    at new CompilerService (/Users/marcopetreri/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:1754:21)
    at new Project (/Users/marcopetreri/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:705:36)
    at ProjectService.createProject (/Users/marcopetreri/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:1726:23)
    at ProjectService.openConfigFile (/Users/marcopetreri/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:1629:28)
    at ProjectService.openOrUpdateConfiguredProjectForFile (/Users/marcopetreri/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:1489:41)
    at ProjectService.openClientFile (/Users/marcopetreri/.vscode/extensions/angular.ng-template-0.800.0/server/editorServices.js:1407:23)
    at /Users/marcopetreri/.vscode/extensions/angular.ng-template-0.800.0/server/documents.js:180:38
    at TextDocuments.logErrors (/Users/marcopetreri/.vscode/extensions/angular.ng-template-0.800.0/server/documents.js:235:13)
    at /Users/marcopetreri/.vscode/extensions/angular.ng-template-0.800.0/server/documents.js:173:74
    at handleNotification (/Users/marcopetreri/.vscode/extensions/angular.ng-template-0.800.0/server/node_modules/vscode-jsonrpc/lib/main.js:489:43)
[Error - 2:37:03 PM] Notification handler 'textDocument/didSave' failed with message: this.ngHost.setSite is not a function

Angular CLI version output

Node: 12.6.0
OS: darwin x64
Angular: 8.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.801.0
@angular-devkit/build-angular      0.801.0
@angular-devkit/build-ng-packagr   0.801.0
@angular-devkit/build-optimizer    0.801.0
@angular-devkit/build-webpack      0.801.0
@angular-devkit/core               8.1.0
@angular-devkit/schematics         8.1.0
@ngtools/json-schema               1.1.0
@ngtools/webpack                   8.1.0
@schematics/angular                8.1.0
@schematics/update                 0.801.0
ng-packagr                         5.3.0
rxjs                               6.4.0
typescript                         3.4.5
webpack                            4.35.2

@justerest
Copy link

Temporary solution

You can downgrade local version of @angular/language-service to 8.0.3.

Снимок экрана 2019-07-05 в 12 20 07

luisfpg pushed a commit to cyclosproject/cyclos4-ui that referenced this issue Jul 5, 2019
luisfpg pushed a commit to cyclosproject/cyclos4-ui that referenced this issue Jul 5, 2019
@sanket-bhalerao
Copy link

Is the fix going to be released any time soon?

@lucas-labs
Copy link

Same problem here. The extension isn't working at all. Here's my output:

Search path: c:/Users/lucas/***/src/app/components/app
Config file name: c:/Users/lucas/***/tsconfig.json
Angular Language Service: 8.1.0
TypeScript: 3.4.5
SERVER ERROR: this.ngHost.setSite is not a function
TypeError: this.ngHost.setSite is not a function
    at new CompilerService (c:\Users\lucas\.vscode\extensions\angular.ng-template-0.800.0\server\editorServices.js:1754:21)
    at new Project (c:\Users\lucas\.vscode\extensions\angular.ng-template-0.800.0\server\editorServices.js:705:36)
    at ProjectService.createProject (c:\Users\lucas\.vscode\extensions\angular.ng-template-0.800.0\server\editorServices.js:1726:23)
    at ProjectService.openConfigFile (c:\Users\lucas\.vscode\extensions\angular.ng-template-0.800.0\server\editorServices.js:1629:28)
    at ProjectService.openOrUpdateConfiguredProjectForFile (c:\Users\lucas\.vscode\extensions\angular.ng-template-0.800.0\server\editorServices.js:1489:41)
    at ProjectService.openClientFile (c:\Users\lucas\.vscode\extensions\angular.ng-template-0.800.0\server\editorServices.js:1407:23)
    at c:\Users\lucas\.vscode\extensions\angular.ng-template-0.800.0\server\documents.js:135:47
    at TextDocuments.logErrors (c:\Users\lucas\.vscode\extensions\angular.ng-template-0.800.0\server\documents.js:235:13)
    at c:\Users\lucas\.vscode\extensions\angular.ng-template-0.800.0\server\documents.js:131:74
    at handleNotification (c:\Users\lucas\.vscode\extensions\angular.ng-template-0.800.0\server\node_modules\vscode-jsonrpc\lib\main.js:489:43)

@david0178418
Copy link

Save as everyone above.

@BlindDespair
Copy link

Having same issue here.

@mucbits
Copy link

mucbits commented Jul 11, 2019

Problem still exists in version 8.1.1

Angular Language Service: 8.1.1
TypeScript: 3.4.5
SERVER ERROR: this.ngHost.setSite is not a function
TypeError: this.ngHost.setSite is not a function

@donsumayan
Copy link

Same issue as everyone

@baratgabor
Copy link

Same issue here as well, with 8.1.1.

@kyliau kyliau self-assigned this Jul 15, 2019
@kyliau
Copy link
Contributor

kyliau commented Jul 15, 2019

Thank you @andrius-pra for fixing this. I apologize for the regression, it was totally my oversight for failing to take into account the breaking change here. Version 0.801.1 has been released on the marketplace.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.