-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doest Not Work with Angular HTML Template and VS Code #217
Comments
@jontiefer did you have a look at the output section of VS Code? There you should find logs from the Language-Service plugin, which might give more details on your case. |
Related: #214 |
Can you try the work around mentioned in #214? |
I'm using Angular CLI v1.6.4 Up until two days ago I had intellisense and file reference links in my HTML templates. That functionality seems to be missing now. Think the latest release is causing some issue with my current setup (saw that the extension auto updated recently) |
I tried the workaround in #214 and it didn't seem to change anything. Maybe I did it wrong? I didn't see the Angular Language Service version change both times I tired to run it. I just ran Here's what I get freshly opening VSCode on a html file and then trying to hover on a half completed variable name:
after that, |
@rfuhrer Did you run |
You don't have to do a It seems like there's just some kind of disconnect between the HTML and the .ts cause you can see the language service doing stuff while inside a .ts file and it's showing all the nice intellisense stuff:
|
Have you tried this with #220 should address this issue. |
Yeah it auto updated the extension as @briancodes mentioned. I could manually try installing it with the VSIX but it says 0.18 in the extension screen |
The fact that What is the |
@briancodes Can you produce a project that I can clone that reproduces this? |
Same here, after upgrade to 0.1.8, it stopped working in |
It's broken for me as well:
I've applied the workaround #214 but it still doesn't work. |
@chuckjaz Hi. I created a new project with the latest CLI and Angular versions (updated to the latest stable released CLI today). Also have the latest stable VSCode version https://github.com/briancodes/language-ext-issue217 I put in the details of what is occuring in the Note: I added a branch
|
Angular Language Service: 5.2.1 All failed...... emergency, could not working without it! |
0.1.8 isn't working for me either on HTML templates with Angular 5.2.2, TypeScript 2.6.2, and VS Code 1.19.3. My workaround currently is reverting vscode-ng-language-service to 0.1.7 found here: https://github.com/angular/vscode-ng-language-service/releases/tag/0.1.7 |
Can confirm that reverting to 0.1.7 made everything work properly again despite being on the latest version of angular, typescript and VSCode |
@briancodes I cloned https://github.com/briancodes/language-ext-issue217 and it works for me. I suspect that it might be an issue with paths on Windows so I am trying that now. |
Out of interest @ryanbuening , what's the process for reverting an extension? I'm guessing it's not supported by VSCode out of the box |
@briancodes revert, bang out #223 in 5 minutes and call it 0.1.9 😄. This extension should just be made version 1.0 it's so damn useful and the "experimental" tag might scare some more conservative users. 🎉 I'm sure it's just a stupid / vs \ error or something equally annoying thanks to windows amazing pathing |
@briancodes I reproduced this in Windows. Investigating now. |
@briancodes You need to Disable Auto Updating Extensions and then select Install from VSIX... |
It is a path issue and an apparent change in TypeScript I was unaware of. We pass the result of A temporary work around is to change the line: containingFile = path.join(this.options.basePath, 'index.ts'); to: containingFile = path.posix.join(this.options.basePath, 'index.ts'); in the file I will make this change in |
@briancodes @jontiefer @ryanbuening Can one of you (or anyone else on the thread) test https://github.com/angular/vscode-ng-language-service/releases/tag/0.1.9 on Windows using your projects? I believe this fixes the Windows issue as described above. |
@chuckjaz Great Success! |
@rfuhrer Thanks! |
@chuckjaz I didn't realised how much I relied on this language extension until it stopped working:-) Great job |
Good stuff! Lesson learned: Next time I'll mention I'm on Windows when making a comment. |
Having this same problem again.
Maybe I goofed? |
Maybe I didn't understand how this plugin should be used. |
It works now. Just make sure you have no TypeScript errors which was issue in my usecase Hotell/react-tools-for-better-angular-apps#2 can this be closed @chuckjaz ? thanks! |
@michaeljmonte after change typescript version same as vscode's; or change "typescript.tsdk" to "./node_modules/typescript/lib", the plugin work again; hope it can help you |
Still not work on Mac since Angular 6... |
I tried to install the extension manually but it didn't work with my project now: Is there any work around this issue because I need this work like before ? |
Same here, the completion does not work on vscode for a
|
Same, not working.
Was wondering if the extension was still updated? Last commit is 2 months ago (okay it's not outdated yet ;)) but this issue is about 10 months old now and it seems to be a quite critical one. |
Not working for me in HTML files at all, no completion, no go-to
edit: Ok, as per: I added
to my tsconfig. Things seem to have started working (though it's spend a very long time and continuous cpu on initialize ts language features, hopefully that's a one off). |
I had this problem too, but finally I found that I set wrong syntax in |
try it, may be solved VSCode - User Settings "editor.snippetSuggestions": "top", to "editor.snippetSuggestions": "inline", |
Closing this, since issue was solved in #217 (comment) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm not sure what I am doing wrong, but I cannot get any intellisense or editor support for Angular HTML templates with VS Code after installing this template.. It simply does not work. Neither do I see any color coding or intellisense, everything is pretty much hand-typed like in notepad right now for me with Angular HTML templates.
The text was updated successfully, but these errors were encountered: