New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String interpolation before inline template breaks language features #1872
Labels
Comments
atscott
added a commit
to atscott/vscode-ng-language-service
that referenced
this issue
Sep 12, 2023
This probably still has its own issues but seems to be at least an improvement over past scanner issues. It may be good to spend more time on the correctness of this or just `ts.createSourceFile`. This previously wasn't done due to perfomance concerns. fixes angular#1872
atscott
added a commit
that referenced
this issue
Sep 22, 2023
…ion (#1922) This probably still has its own issues but seems to be at least an improvement over past scanner issues. It may be good to spend more time on the correctness of this or just `ts.createSourceFile`. This previously wasn't done due to perfomance concerns. fixes #1872 (cherry picked from commit bd6282e)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 bug report
Is this a regression?
No
Description
Adding a string interpolation before an inline template breaks the language features of the template.
Reproduction
vscode-ng-language-service/integration/project/app/app.component.ts
Line 2 in e9c2438
above the component definition
- Hover over the template variable again. Quick info will not appear
Additional info
It appears that the string interpolation is breaking the TypeScript scanner/tokenizer. The code which checks to see if a location is inside a template region no longer works as a result:
vscode-ng-language-service/client/src/embedded_support.ts
Line 70 in e9c2438
The text was updated successfully, but these errors were encountered: