Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@fileoverview in file with async gets moved #1095

Open
evmar opened this issue Oct 4, 2019 · 2 comments
Open

@fileoverview in file with async gets moved #1095

evmar opened this issue Oct 4, 2019 · 2 comments
Labels
internal-issue-created Google internal issue has been created for this

Comments

@evmar
Copy link
Contributor

evmar commented Oct 4, 2019

Consider a file like:

/** @fileoverview foo */

codeHere();

If codeHere is export {}; async function ... or export async function ... the fileoverview comment transformer causes the fileoverview to be moved down below the goog.module etc in the emit.

But if instead it's async function ... or export function ... then it stays at the top!

It seems to be some interaction with the many weird things the fileoverview transformer does, along with maybe how export/async are downlevelled.

@evmar
Copy link
Contributor Author

evmar commented Oct 4, 2019

I tinkered a bit with some of the fileoverview transformer functions (e.g. we have code in there that links to bugs that have since been fixed) but nothing jumped out at me.

@brad4d
Copy link
Contributor

brad4d commented Oct 7, 2019

Created Google internal issue http://b/142269197

@brad4d brad4d added the internal-issue-created Google internal issue has been created for this label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-issue-created Google internal issue has been created for this
Projects
None yet
Development

No branches or pull requests

2 participants