Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect imports in lib/index.ts #5325

Closed
sandersn opened this issue Sep 30, 2019 · 3 comments · Fixed by #5326
Closed

Incorrect imports in lib/index.ts #5325

sandersn opened this issue Sep 30, 2019 · 3 comments · Fixed by #5326

Comments

@sandersn
Copy link
Contributor

sandersn commented Sep 30, 2019

  • Typescript: 3.7, currently available as typescript@3.7.0-beta
  • Protractor Version: master

lib/index.ts incorrectly re-exports two types from plugins.ts:

import {PluginConfig, ProtractorPlugin} from './plugins';
export type PluginConfig = PluginConfig;
export type ProtractorPlugin = ProtractorPlugin;

The references in the type aliases should be circular, but in current versions of Typescript, are not. The correct way to write this is:

export {PluginConfig, ProtractorPlugin} from './plugins';

In Typescript 3.7 the current code will be an error. The beta is available as typescript@3.7.0-beta.

I'll create a PR shortly with the fix.

@esturkce
Copy link

I got the same error, is there a solution yet?
thanks

@userJulienMoreau
Copy link

I have the same error, for the moment I downgrade for typescript 3.6.4

@beh-rouz
Copy link

Same issue here, when I updated my angular project from version 8.x.x to 9.x.x and tried to get a production build with ng build -c <config> but eventually found a way to get around it.

I just removed node_modules, package-lock.json and run npm install.

$ rm -rf node_modules/ package-lock.json
$ npm install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants