Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer GitHub releases until after NPM packages are published #747

Open
dgp1130 opened this issue Aug 2, 2022 · 1 comment
Open

Defer GitHub releases until after NPM packages are published #747

dgp1130 opened this issue Aug 2, 2022 · 1 comment

Comments

@dgp1130
Copy link

dgp1130 commented Aug 2, 2022

Action item from requiem/doc/postmortem475066.

In the 14.1.0-rc.0 release, the NPM publish operation failed several times. However the GitHub release was published before NPM failed, so each attempt published a GitHub release which isn't actually usable and confuses people watching the repository. These phantom releases also need to be manually cleaned up afterwards.

We should consider deferring the GitHub release until after the NPM publish is successful. If the NPM publish does fail, we might want to print an error message that the GitHub release was not posted, but that's probably less of a concern.

@devversion
Copy link
Member

That is an interesting point. I specifically made it run before any NPM release is cut so that it is "usually" trivial to just finish the remaining NPM publishes, but not having to e.g. manually create the tag, release entry (with changelog etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants