Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment to Google Cloud Run using Angular v17 Application Builder not working #3502

Open
nicky-lenaers opened this issue Feb 23, 2024 · 0 comments

Comments

@nicky-lenaers
Copy link

Version info

Angular:
17.2.2
Firebase:
13.3.1
AngularFire:
17.0.1
Other (e.g. Ionic/Cordova, Node, browser, operating system):
Node 20

How to reproduce these conditions

Use @angular/fire with the new @angular-devkit/build-angular:application.
Failing test unit, Stackblitz demonstrating the problem

Steps to set up and reproduce
Start a new repo with the following configuration (I used Nx with project.json, but vanilla angular.json also works):

  // ...
  "targets": {
    "build": {
      "executor": "@angular-devkit/build-angular:application",
      "outputs": ["{options.outputPath}"],
      "options": {
        "outputPath": "dist/apps/app",
      }
    }
    "deploy": {
      "executor": "@angular/fire:deploy",
      "configurations": {
        "production": {
          "buildTarget": "app:build:production",
          "serveTarget": "app:build:production"
        }
      },
}

Then execute the target using npx nx run app:build --configuration=production. This creates the following structre:

dist/
  |_ apps/
    |_ app/
      |_ browser/
      |_ server/
        |_ ...
        |_ main.server.mjs
        |_ server.mjs

But this code to deploy to Cloud Run still uses the old main.js. Also, it is using the outputPath from the build target, but since that outputPath does not contain browser or server, the final path needs to have this folder added too.

The change can be something like this (I have not tested this):

const packageJson = getPackageJson(context, workspaceRoot, options, join(serverBuildOptions.outputPath, 'main.js'));

...to something like this:

const packageJson = getPackageJson(context, workspaceRoot, options, join(serverBuildOptions.outputPath, 'server', 'main.server.mjs'));

...and probably more than this.

Sample data and security rules

Debug output

** Errors in the JavaScript console **

** Output from firebase.database().enableLogging(true); **

** Screenshots **

Expected behavior

Upload to Cloud Run using Angular v17 @angular-devkit/build-angular:application should work.

Actual behavior

Upload to Cloud Run fails for Angular v17 with @angular-devkit/build-angular:application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant