Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation broken link #54227

Closed
johnnygerard opened this issue Feb 3, 2024 · 5 comments
Closed

Documentation broken link #54227

johnnygerard opened this issue Feb 3, 2024 · 5 comments
Labels
area: adev Angular.dev documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR
Milestone

Comments

@johnnygerard
Copy link
Contributor

Describe the problem that you experienced

The ChangeDetectionStrategy has a broken link.

Here is the correct link: ChangeDetectorRef Usage Notes

Enter the URL of the topic with the problem

No response

Describe what you were looking for in the documentation

No response

Describe the actions that led you to experience the problem

No response

Describe what you want to experience that would fix the problem

No response

Add a screenshot if that helps illustrate the problem

No response

If this problem caused an exception or error, please paste it here

No response

If the problem is browser-specific, please specify the device, OS, browser, and version

No response

Provide any additional information here in as much as detail as you can

No response

@JeanMeche
Copy link
Member

Hi, thanks for reporting this.
Btw, we have the same issue on https://angular.dev/api/core/ViewRef

@JeanMeche JeanMeche added the area: adev Angular.dev documentation label Feb 3, 2024
@ngbot ngbot bot added this to the needsTriage milestone Feb 3, 2024
@ferrorenan
Copy link
Contributor

@JeanMeche Hey Jean, I'm trying to find it in the adev repository to tweak it, but I can't find it. Do you have any idea where this is?!

@JeanMeche
Copy link
Member

This part is handled in the dev-infra repo, which makes the change a bit more compilated.

https://github.com/angular/dev-infra

@bencodezen bencodezen added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Mar 13, 2024
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Mar 13, 2024
@JeanMeche
Copy link
Member

Soooo, the 2 PR linked above helped a bit but now I stumbled upon a Typescript bug : microsoft/TypeScript#58259.

This will require us to wait for an Typescriot update of our stack once the bug is fixed & released.

JeanMeche added a commit to JeanMeche/angular that referenced this issue Apr 25, 2024
AndrewKushnir pushed a commit that referenced this issue Apr 26, 2024
AndrewKushnir pushed a commit that referenced this issue Apr 26, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: adev Angular.dev documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent state: has PR
Projects
None yet
4 participants