Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add generics support to AbstractControl.get method #16769

Closed
desfero opened this issue May 13, 2017 · 3 comments
Closed

[Feature] Add generics support to AbstractControl.get method #16769

desfero opened this issue May 13, 2017 · 3 comments

Comments

@desfero
Copy link

desfero commented May 13, 2017

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[x ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

What is the motivation / use case for changing the behavior?
To get custom controls without typescript assertions.

Can be implemented as follow (assuming TypeScript 2.3 'Generic parameter defaults')

get<T extends AbstractControl = AbstractControl>(path: Array<string|number>|string): T|null { ... }

Current behavior

class CustomFormControl extends FormControl {
  doSomething() ...
}

const formGroup = new FormGroup({
    foo: new CustomFormContro(),
})

const fooControl: CustomFormControl = formGroup.get('foo') as CustomFormControl;
fooControl.doSomething();

Featured behavior

class CustomFormControl extends FormControl {
  doSomething() ...
}

const formGroup = new FormGroup({
    foo: new CustomFormContro(),
})

const fooControl= formGroup.get<CustomFormControl>('foo');
fooControl.doSomething();

If that make sense let me know and i will submit a PR

@Simon-Briggs
Copy link

related?: #13721 (comment)

@desfero
Copy link
Author

desfero commented May 15, 2017

Yes, you are right. Thanks

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants