Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic router-outlets #12629

Closed
olegdunkan opened this issue Oct 31, 2016 · 5 comments
Closed

Dynamic router-outlets #12629

olegdunkan opened this issue Oct 31, 2016 · 5 comments
Labels
area: router feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature
Milestone

Comments

@olegdunkan
Copy link
Contributor

olegdunkan commented Oct 31, 2016

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Let say we have this code:

@Component({
    selector:'my-app',
    template:`
    <h2>Chess</h2>
    <router-outlet [attr.name]="'a'"></router-outlet>
    <router-outlet [attr.name]="'b'"></router-outlet>
    <router-outlet *ngFor="let name of ['c', 'd']" [attr.name]="name"></router-outlet>
`
})
class Chess {}

It doesn't work and it is right. Attribute in router-outlet directive is like a 'const' modifier in typescript. You can set it only manually in a template.
But what if I develop application and set routes and outlets dynamically. How expensive it will be to allow router-outlet directive to be dynamic?

@vsavkin vsavkin added area: router feature Issue that requests a new feature labels Oct 31, 2016
@vsavkin
Copy link
Contributor

vsavkin commented Oct 31, 2016

It should work once the following is implemented:
#12522

@ngbot ngbot bot added this to the Backlog milestone Jan 23, 2018
@angular-robot angular-robot bot added the feature: votes required Feature request which is currently still in the voting phase label Jun 4, 2021
@angular-robot
Copy link
Contributor

angular-robot bot commented Jun 4, 2021

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link
Contributor

angular-robot bot commented Jun 24, 2021

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added the feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors label Jun 24, 2021
@atscott
Copy link
Contributor

atscott commented Sep 15, 2021

Closing as duplicate of #12522

@atscott atscott closed this as completed Sep 15, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: router feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests

4 participants
@vsavkin @atscott @olegdunkan and others