Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Replace:true support for components() ? #14078

Closed
geroyche opened this issue Feb 18, 2016 · 11 comments
Closed

Replace:true support for components() ? #14078

geroyche opened this issue Feb 18, 2016 · 11 comments

Comments

@geroyche
Copy link

Components don't support replace: true.
I realize they are eventually meant to facilitate migration to 2.0, but I still wonder whether they shouldn't support replace, seeing how they are 1.x feature.

why am i asking?
i am trying to style my app with a bootstrap template (not angular-ui, just a generic bootstrap css theme) and this:
#13805
is a huge issue (also going forward with 2.0 i guess).

@Narretz
Copy link
Contributor

Narretz commented Feb 18, 2016

-1
Replace is deprecated in 1.x and we encourage people to remove it from their directives. It's buggy and custom elements are actuallt the replacement for replace so to speak. Bootstrap should really fix their css imo.

@Narretz
Copy link
Contributor

Narretz commented Feb 21, 2016

Yeah, I don't think this is gonna happen.

@Narretz Narretz closed this as completed Feb 21, 2016
@tomer78
Copy link

tomer78 commented Sep 15, 2016

Angular material and flex css also has major problems with the fact that component/directives are wrapped inside a container tag.
Anyone has an idea how to handle that issue?

@paul-asvb
Copy link

@tomer78 I just ran into the same problem.
Did you find a suitable solution ?

@angelxmoreno
Copy link

angelxmoreno commented Dec 22, 2016

Is there at least a work-around ? The only (non-viable) solution I see is to go back and redo all of the css targeting :-P

@gkalpak
Copy link
Member

gkalpak commented Dec 23, 2016

@angelxmoreno, you can use directive instead, but keep in mind that replace: true is deprecated and not recommended.

@beazergood
Copy link

I too am experiencing this issue when trying to leverage Angular Material layout structures. My component tags are an intermediary tag which break the layout-fill chain I need in order to achieve the layouts I'm after. Surely i'm not the only one?! Does anyone have any suggestions?

@jasonwatt
Copy link

jasonwatt commented Aug 16, 2017

or at a minimum remove the need to a template to have a wrapping html tag.

this html wrapper in html wrapper BS sucks for flex box design and makes it nearly impossible.

EDIT: I just realized you can make component template without a wrapping element for the templat like you needed to for directives. this makes things a whole lot simpler

@aijazkhan81
Copy link

@jasonwatt How do you do that?

@rajatvijay
Copy link

Yeah @jasonwatt
How did you do that?

@jbedard jbedard reopened this Feb 24, 2018
@jbedard
Copy link
Contributor

jbedard commented Feb 24, 2018

Oops. Wrong button. Dang phone...

@jbedard jbedard closed this as completed Feb 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests